Update docs files

Signed-off-by: Timo Sand <timo.sand@f-secure.com>

Author: deiga

ARCHITECTURE.md

@@ -65,7 +65,7 @@ terraform-provider-github/
 │   └── transport.go             # Custom HTTP transport with ETag caching
 │
 ├── ARCHITECTURE.md              # This file - implementation guide
-├── MAINTAINERS.md               # Maintainers, decision log, contributors
+├── MAINTAINERS.md               # Maintainers and contributors
 └── CONTRIBUTING.md              # How to contribute
 ```
 
@@ -301,7 +301,7 @@ func resourceGithubExampleDelete(ctx context.Context, d *schema.ResourceData, me
 ```go
 func resourceExampleRead(ctx context.Context, d *schema.ResourceData, m any) diag.Diagnostics {
     meta := m.(*Owner)
-    // REST API client (go-github v82)
+    // REST API client (go-github)
     client := meta.v3client
 
     // GraphQL client (for queries not available in REST)
@@ -326,7 +326,7 @@ if err != nil {
     var ghErr *github.ErrorResponse
     if errors.As(err, &ghErr) {
         if ghErr.Response.StatusCode == http.StatusNotFound {
-            log.Printf("[INFO] Removing %s from state because it no longer exists", name)
+            tflog.Info(ctx, "Removing resource from state because it no longer exists", map[string]any{"name": name})
             d.SetId("")
             return nil
         }
@@ -446,10 +446,21 @@ func resourceExampleCreate(ctx context.Context, d *schema.ResourceData, meta any
 
 ### Test Structure
 
+Use `ConfigStateChecks` for post-apply state assertions and `ConfigPlanChecks` for plan-level assertions (e.g., verifying `ForceNew` triggers). These replace the legacy `Check:` + `resource.ComposeTestCheckFunc` pattern.
+
 ```go
+import (
+    "github.com/hashicorp/terraform-plugin-testing/compare"
+    "github.com/hashicorp/terraform-plugin-testing/helper/resource"
+    "github.com/hashicorp/terraform-plugin-testing/knownvalue"
+    "github.com/hashicorp/terraform-plugin-testing/plancheck"
+    "github.com/hashicorp/terraform-plugin-testing/statecheck"
+    "github.com/hashicorp/terraform-plugin-testing/tfjsonpath"
+)
+
 func TestAccGithubExample(t *testing.T) {
-  
-  t.Run("creates resource without error", func(t *testing.T) {
+
+    t.Run("creates resource without error", func(t *testing.T) {
         randomID := acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum)
         testResourceName := fmt.Sprintf("%s%s", testResourcePrefix, randomID)
         config := fmt.Sprintf(`
@@ -464,16 +475,42 @@ func TestAccGithubExample(t *testing.T) {
             Steps: []resource.TestStep{
                 {
                     Config: config,
-                    Check: resource.ComposeTestCheckFunc(
-                        resource.TestCheckResourceAttr( "github_example.test", "name", testResourceName ),
-                    ),
+                    ConfigStateChecks: []statecheck.StateCheck{
+                        // Verify computed values are populated
+                        statecheck.ExpectKnownValue("github_example.test", tfjsonpath.New("etag"), knownvalue.NotNull()),
+                        statecheck.ExpectKnownValue("github_example.test", tfjsonpath.New("node_id"), knownvalue.NotNull()),
+                        // Compare computed values across resources
+                        statecheck.CompareValuePairs("github_example.test", tfjsonpath.New("repo_id"), "github_repository.test", tfjsonpath.New("repo_id"), compare.ValuesSame()),
+                    },
+                },
+            },
+        })
+    })
+
+    t.Run("forces new when field changes", func(t *testing.T) {
+        // ... config steps ...
+
+        resource.Test(t, resource.TestCase{
+            PreCheck:          func() { skipUnauthenticated(t) },
+            ProviderFactories: providerFactories,
+            Steps: []resource.TestStep{
+                {Config: configBefore},
+                {
+                    Config: configAfter,
+                    ConfigPlanChecks: resource.ConfigPlanChecks{
+                        PreApply: []plancheck.PlanCheck{
+                            plancheck.ExpectResourceAction("github_example.test", plancheck.ResourceActionDestroyBeforeCreate),
+                        },
+                    },
                 },
             },
         })
     })
 }
 ```
 
+> **Legacy pattern:** Existing tests may still use `Check: resource.ComposeTestCheckFunc(...)`. New tests should use `ConfigStateChecks` and `ConfigPlanChecks` instead. See `data_source_github_ip_ranges_test.go` for a real-world example.
+
 ### Test Modes
 
 Use `skipUnauthenticated(t)`, `skipUnlessHasOrgs(t)`, `skipUnlessHasPaidOrgs(t)`, `skipUnlessEnterprise(t)`, `skipUnlessMode(t, testModes...)` functions to run tests in appropriate contexts:
@@ -537,10 +574,8 @@ The following resources are deprecated and will be removed in future versions:
 
 ### Pending go-github Updates
 
-Several features are blocked waiting for go-github v68+:
+The following features are blocked waiting for upstream changes in [google/go-github#3364](https://github.com/google/go-github/issues/3364) (adds `assignment`, `parent_team_id`, `parent_team_slug` fields):
 
-- `data_source_github_organization_repository_role.go:56`
-- `resource_github_organization_repository_role.go:102`
 - `data_source_github_organization_role_users.go:41`
 - `data_source_github_organization_role_teams.go:51`
 
@@ -564,6 +599,10 @@ Several features are blocked waiting for go-github v68+:
 | `expandStringList([]any)`                                   | Convert to `[]string`                          |
 | `flattenStringList([]string)`                               | Convert to `[]any`                             |
 | `deleteResourceOn404AndSwallow304OtherwiseReturnError(...)` | Handle 404/304 responses                       |
+| `diffRepository`                                            | `CustomizeDiffFunc`: force replacement on repo ID change |
+| `diffSecret`                                                | `CustomizeDiffFunc`: detect remote secret drift via timestamps |
+| `diffSecretVariableVisibility`                              | `CustomizeDiffFunc`: validate `selected_repository_ids` vs `visibility` |
+| `diffTeam`                                                  | `CustomizeDiffFunc`: force new resource on team ID change |
 
 ### Naming Conventions
 
@@ -614,6 +653,14 @@ Several features are blocked waiting for go-github v68+:
 
 **Reference:** <https://github.com/integrations/terraform-provider-github/issues/2709#issuecomment-3811466444>
 
+#### Migrate to `terraform-plugin-testing`
+
+**Decision:** Migrate from the SDK testing package (`github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource`) to `terraform-plugin-testing` (`github.com/hashicorp/terraform-plugin-testing`). Use `ConfigStateChecks` and `ConfigPlanChecks` as the preferred assertion patterns, replacing `Check:` + `resource.ComposeTestCheckFunc`.
+
+**Rationale:** `terraform-plugin-testing` is the standalone testing framework that decouples test utilities from the SDK. `ConfigStateChecks` and `ConfigPlanChecks` provide type-safe, composable assertions with better error messages.
+
+**Reference:** <https://developer.hashicorp.com/terraform/plugin/testing>
+
 #### No Local Git CLI Support
 
 **Decision:** Do not support using local git CLI to operate on repositories; use purely API operations.

CONTRIBUTING.md

@@ -53,8 +53,8 @@ Once you have the repository cloned, there's a couple of additional steps you'll
 
 ### Local Development Iteration
 
-1. Write a test describing what you will fix. See [`github_label`](./github/resource_github_issue_label_test.go) for an example format.
-2. Run your test and observe it fail. Enabling debug output allows for observing the underlying requests and responses made as well as viewing state (search `STATE:`) generated during the acceptance test run.
+1. Write a test describing what you will fix. See [`github_ip_ranges`](./github/data_source_github_ip_ranges_test.go) for an example using the preferred `ConfigStateChecks` pattern, and [ARCHITECTURE.md](ARCHITECTURE.md#test-structure) for full guidance.
+2. Run your test and observe it fail. Enabling debug output allows for observing the underlying requests and responses made during the acceptance test run.
 
 ```sh
 TF_LOG=DEBUG make testacc T=TestAccGithubIssueLabel

MAINTAINERS.md

@@ -17,3 +17,7 @@ This document lists the current maintainers of the Terraform Provider for GitHub
 | Name            | GitHub                                       |
 | --------------- | -------------------------------------------- |
 | Keegan Campbell | [@kfcampbell](https://github.com/kfcampbell) |
+
+## Contributors
+
+See the full list of contributors on [GitHub](https://github.com/integrations/terraform-provider-github/graphs/contributors).