fix: remove unnecessary Read in Create functions

sheeeng · sheeeng · commit 7ca2562e7698 · 2026-03-02T21:21:20.000-08:00
Remove explicit Read function calls at the end of
Create functions for
`actions_organization_permissions` and
`actions_repository_permissions`.

Signed-off-by: Leonard Sheng Sheng Lee &lt;305414+sheeeng@users.noreply.github.com&gt;
diff --git a/github/resource_github_actions_organization_permissions.go b/github/resource_github_actions_organization_permissions.go
@@ -195,7 +195,7 @@ func resourceGithubActionsOrganizationPermissionsCreate(ctx context.Context, d *
 	}
 
 	d.SetId(orgName)
-	return resourceGithubActionsOrganizationPermissionsRead(ctx, d, meta)
+	return nil
 }
 
 func resourceGithubActionsOrganizationPermissionsUpdate(ctx context.Context, d *schema.ResourceData, meta any) diag.Diagnostics {
diff --git a/github/resource_github_actions_repository_permissions.go b/github/resource_github_actions_repository_permissions.go
@@ -123,7 +123,7 @@ func resourceGithubActionsRepositoryPermissionsCreate(ctx context.Context, d *sc
 		Enabled: &enabled,
 	}
 
-	// Only specify `allowed_actions` if actions are enabled
+	// Only specify `allowed_actions` if actions are enabled.
 	if enabled {
 		repoActionPermissions.AllowedActions = &allowedActions
 	}
@@ -158,7 +158,7 @@ func resourceGithubActionsRepositoryPermissionsCreate(ctx context.Context, d *sc
 	}
 
 	d.SetId(repoName)
-	return resourceGithubActionsRepositoryPermissionsRead(ctx, d, meta)
+	return nil
 }
 
 func resourceGithubActionsRepositoryPermissionsUpdate(ctx context.Context, d *schema.ResourceData, meta any) diag.Diagnostics {

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ func resourceGithubActionsOrganizationPermissionsCreate(ctx context.Context, d *`
`195`	`195`	`}`
`196`	`196`
`197`	`197`	`d.SetId(orgName)`
`198`		`- return resourceGithubActionsOrganizationPermissionsRead(ctx, d, meta)`
	`198`	`+ return nil`
`199`	`199`	`}`
`200`	`200`
`201`	`201`	`func resourceGithubActionsOrganizationPermissionsUpdate(ctx context.Context, d *schema.ResourceData, meta any) diag.Diagnostics {`
Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ func resourceGithubActionsRepositoryPermissionsCreate(ctx context.Context, d *sc`
`123`	`123`	`Enabled: &enabled,`
`124`	`124`	`}`
`125`	`125`
`126`		- // Only specify `allowed_actions` if actions are enabled
	`126`	+ // Only specify `allowed_actions` if actions are enabled.
`127`	`127`	`if enabled {`
`128`	`128`	`repoActionPermissions.AllowedActions = &allowedActions`
`129`	`129`	`}`
`@@ -158,7 +158,7 @@ func resourceGithubActionsRepositoryPermissionsCreate(ctx context.Context, d *sc`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`d.SetId(repoName)`
`161`		`- return resourceGithubActionsRepositoryPermissionsRead(ctx, d, meta)`
	`161`	`+ return nil`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`func resourceGithubActionsRepositoryPermissionsUpdate(ctx context.Context, d *schema.ResourceData, meta any) diag.Diagnostics {`