Remove unnecessary d.Set("role_id")

deiga · deiga · commit 8058dbd913eb · 2026-02-17T22:56:29.000+02:00
Signed-off-by: Timo Sand &lt;timo.sand@f-secure.com&gt;
diff --git a/github/resource_github_organization_repository_role.go b/github/resource_github_organization_repository_role.go
@@ -170,15 +170,11 @@ func resourceGithubOrganizationRepositoryRoleUpdate(ctx context.Context, d *sche
 		Permissions: permissionsStr,
 	}
 
-	role, _, err := client.Organizations.UpdateCustomRepoRole(ctx, orgName, roleId, update)
+	_, _, err = client.Organizations.UpdateCustomRepoRole(ctx, orgName, roleId, update)
 	if err != nil {
 		return diag.FromErr(fmt.Errorf("error updating GitHub organization repository role (%s/%s): %w", orgName, d.Get("name").(string), err))
 	}
 
-	if err = d.Set("role_id", role.GetID()); err != nil {
-		return diag.FromErr(err)
-	}
-
 	return nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -170,15 +170,11 @@ func resourceGithubOrganizationRepositoryRoleUpdate(ctx context.Context, d *sche`
`170`	`170`	`Permissions: permissionsStr,`
`171`	`171`	`}`
`172`	`172`
`173`		`- role, _, err := client.Organizations.UpdateCustomRepoRole(ctx, orgName, roleId, update)`
	`173`	`+ _, _, err = client.Organizations.UpdateCustomRepoRole(ctx, orgName, roleId, update)`
`174`	`174`	`if err != nil {`
`175`	`175`	`return diag.FromErr(fmt.Errorf("error updating GitHub organization repository role (%s/%s): %w", orgName, d.Get("name").(string), err))`
`176`	`176`	`}`
`177`	`177`
`178`		`- if err = d.Set("role_id", role.GetID()); err != nil {`
`179`		`- return diag.FromErr(err)`
`180`		`- }`
`181`		`-`
`182`	`178`	`return nil`
`183`	`179`	`}`
`184`	`180`