feat : Support repository property for GitHub organization ruleset (#2356)

* Define schema for repository_property

Refactor expandConditions to reduce complexity
Refactor logic to reduce the  cognitive complexity and add logic to handle the repository_property field
Flatten conditions for repository_property and fix schemas
Add test case when ruleset use repository_property
Refactor repository property conditions to make them optional
Flatten update Target parameters to allow the detection of changes when remote resource is updated
Update documentation

* Apply format in the code base

* Fix repository_property validation and docs

  - Add ValidateFunc to include.source field for consistency with exclude
  - Update docs to mention repository_property as third targeting option
  - Fix missing space in documentation

* Support repository_property in push rulesets

* Remove unused customdiff imports

* Replace custom validation with built-in ExactlyOneOf for repo targeting

Add ExactlyOneOf/AtLeastOneOf to repository_property, repository_name,repository_id fields.
Remove manual validation counting in util_ruleset_validation.Add 3 validation tests for single/multiple/missing repo targeting options.
Addresses PR #2356 review feedback - simplifies validation using schema constraints.

* Rever unintencial change

* Add tests, docs, and fix default handling for repository_property

- Add doc example for repository_property usage
- Add tests for exclude block, multiple properties, and updates
- Fix source field default handling in flatten function to prevent diffs

* Apply suggestions from PR comment

* Add unit tests

* Remove redundant condition

* Updated description based in the GitHub API docs

* Apply linter and fmt

* Remove unnecessary checks

* Remove tests

These tests check validation that was handover to the Terraform built-in validation

* Improve syntax for include and exclude property

Improve e2e tests for the ruleset and improve documentation

* Use t context

* Rewrite tests using the resource_github_organization_custom_properties

Setup the tests case using the config instead of using the API

* Refactor repository property names in organization ruleset tests for consistency

* Refactor tests to use state checks for repository property validation in organization ruleset

* Update repository property references to use default_branch in organization ruleset tests

* Fix: Replace ExactlyOneOf with ConflictsWith/AtLeastOneOf for repository conditions

ExactlyOneOf has known issues with nested optional list blocks in Terraform SDK.
Use ConflictsWith + AtLeastOneOf pattern for reliable "exactly one" validation
across repository_name, repository_id, and repository_property conditions.

Updated test expectations to match new error message format from ConflictsWith.

Addresses feedback from PR #2356 comment r2968116244, references fix from #3235

* Apply lint

Author: Moser-ss

github/resource_github_organization_ruleset.go

@@ -94,7 +94,7 @@ func resourceGithubOrganizationRuleset() *schema.Resource {
 				Type:        schema.TypeList,
 				Optional:    true,
 				MaxItems:    1,
-				Description: "Parameters for an organization ruleset condition. `ref_name` is required for `branch` and `tag` targets, but must not be set for `push` targets. One of `repository_name` or `repository_id` is always required.",
+				Description: "Parameters for an organization ruleset condition.The branch and tag rulesets conditions object should contain both repository_name and ref_name properties, or both repository_id and ref_name properties, or both repository_property and ref_name properties. The push rulesets conditions object does not require the ref_name property.",
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						"ref_name": {
@@ -123,13 +123,85 @@ func resourceGithubOrganizationRuleset() *schema.Resource {
 								},
 							},
 						},
+						"repository_property": {
+							Type:          schema.TypeList,
+							Optional:      true,
+							MaxItems:      1,
+							ConflictsWith: []string{"conditions.0.repository_id", "conditions.0.repository_name"},
+							AtLeastOneOf:  []string{"conditions.0.repository_name", "conditions.0.repository_id", "conditions.0.repository_property"},
+							Description:   "Conditions to target repositories by custom or system properties.",
+							Elem: &schema.Resource{
+								Schema: map[string]*schema.Schema{
+									"include": {
+										Type:        schema.TypeList,
+										Optional:    true,
+										ConfigMode:  schema.SchemaConfigModeAttr,
+										Description: "The repository properties and values to include. All of these properties must match for the condition to pass.",
+										Elem: &schema.Resource{
+											Schema: map[string]*schema.Schema{
+												"name": {
+													Type:        schema.TypeString,
+													Required:    true,
+													Description: "The name of the repository property to target.",
+												},
+												"property_values": {
+													Type:        schema.TypeList,
+													Required:    true,
+													Description: "The values to match for the repository property.",
+													Elem: &schema.Schema{
+														Type: schema.TypeString,
+													},
+												},
+												"source": {
+													Type:             schema.TypeString,
+													Optional:         true,
+													Description:      "The source of the repository property. Defaults to 'custom' if not specified. Can be one of: custom, system",
+													Default:          "custom",
+													ValidateDiagFunc: validation.ToDiagFunc(validation.StringInSlice([]string{"custom", "system"}, false)),
+												},
+											},
+										},
+									},
+									"exclude": {
+										Type:        schema.TypeList,
+										Optional:    true,
+										ConfigMode:  schema.SchemaConfigModeAttr,
+										Description: "The repository properties and values to exclude. The ruleset will not apply if any of these properties match.",
+										Elem: &schema.Resource{
+											Schema: map[string]*schema.Schema{
+												"name": {
+													Type:        schema.TypeString,
+													Required:    true,
+													Description: "The name of the repository property to target.",
+												},
+												"property_values": {
+													Type:        schema.TypeList,
+													Required:    true,
+													Description: "The values to match for the repository property.",
+													Elem: &schema.Schema{
+														Type: schema.TypeString,
+													},
+												},
+												"source": {
+													Type:             schema.TypeString,
+													Optional:         true,
+													Description:      "The source of the repository property. Defaults to 'custom' if not specified. Can be one of: custom, system",
+													Default:          "custom",
+													ValidateDiagFunc: validation.ToDiagFunc(validation.StringInSlice([]string{"custom", "system"}, false)),
+												},
+											},
+										},
+									},
+								},
+							},
+						},
 						"repository_name": {
-							Type:         schema.TypeList,
-							Optional:     true,
-							MaxItems:     1,
-							Description:  "Targets repositories that match the specified name patterns.",
-							ExactlyOneOf: []string{"conditions.0.repository_id"},
-							AtLeastOneOf: []string{"conditions.0.repository_id"},
+							Type:          schema.TypeList,
+							Optional:      true,
+							MaxItems:      1,
+							ConflictsWith: []string{"conditions.0.repository_id", "conditions.0.repository_property"},
+							AtLeastOneOf:  []string{"conditions.0.repository_name", "conditions.0.repository_id", "conditions.0.repository_property"},
+							Description:   "Targets repositories that match the specified name patterns.",
 							Elem: &schema.Resource{
 								Schema: map[string]*schema.Schema{
 									"include": {
@@ -158,9 +230,11 @@ func resourceGithubOrganizationRuleset() *schema.Resource {
 							},
 						},
 						"repository_id": {
-							Type:        schema.TypeList,
-							Optional:    true,
-							Description: "The repository IDs that the ruleset applies to. One of these IDs must match for the condition to pass.",
+							Type:          schema.TypeList,
+							Optional:      true,
+							ConflictsWith: []string{"conditions.0.repository_name", "conditions.0.repository_property"},
+							AtLeastOneOf:  []string{"conditions.0.repository_name", "conditions.0.repository_id", "conditions.0.repository_property"},
+							Description:   "The repository IDs that the ruleset applies to. One of these IDs must match for the ruleset to apply.",
 							Elem: &schema.Schema{
 								Type: schema.TypeInt,
 							},