test(billing-usage): improve acceptance tests with ID format and structural checks

Add assertions for:
- ID format using StringRegexp (e.g. 'slug:billing-usage')
- usage_items and time_period are NotNull
- Additional filter variants (year+month) for billing usage data source

Author: vmvarela

github/data_source_github_enterprise_billing_premium_request_usage_test.go

@@ -2,6 +2,7 @@ package github
 
 import (
 	"fmt"
+	"regexp"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
@@ -29,6 +30,18 @@ func TestAccGithubEnterpriseBillingPremiumRequestUsage(t *testing.T) {
 							tfjsonpath.New("enterprise_slug"),
 							knownvalue.StringExact(testAccConf.enterpriseSlug),
 						),
+						statecheck.ExpectKnownValue("data.github_enterprise_billing_premium_request_usage.test",
+							tfjsonpath.New("id"),
+							knownvalue.StringRegexp(regexp.MustCompile(`^.+:billing-premium-request-usage$`)),
+						),
+						statecheck.ExpectKnownValue("data.github_enterprise_billing_premium_request_usage.test",
+							tfjsonpath.New("usage_items"),
+							knownvalue.NotNull(),
+						),
+						statecheck.ExpectKnownValue("data.github_enterprise_billing_premium_request_usage.test",
+							tfjsonpath.New("time_period"),
+							knownvalue.NotNull(),
+						),
 					},
 				},
 			},
@@ -55,6 +68,14 @@ func TestAccGithubEnterpriseBillingPremiumRequestUsage(t *testing.T) {
 							tfjsonpath.New("enterprise_slug"),
 							knownvalue.StringExact(testAccConf.enterpriseSlug),
 						),
+						statecheck.ExpectKnownValue("data.github_enterprise_billing_premium_request_usage.test",
+							tfjsonpath.New("usage_items"),
+							knownvalue.NotNull(),
+						),
+						statecheck.ExpectKnownValue("data.github_enterprise_billing_premium_request_usage.test",
+							tfjsonpath.New("time_period"),
+							knownvalue.NotNull(),
+						),
 					},
 				},
 			},

github/data_source_github_enterprise_billing_usage_summary_test.go

@@ -2,6 +2,7 @@ package github
 
 import (
 	"fmt"
+	"regexp"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
@@ -29,6 +30,18 @@ func TestAccGithubEnterpriseBillingUsageSummary(t *testing.T) {
 							tfjsonpath.New("enterprise_slug"),
 							knownvalue.StringExact(testAccConf.enterpriseSlug),
 						),
+						statecheck.ExpectKnownValue("data.github_enterprise_billing_usage_summary.test",
+							tfjsonpath.New("id"),
+							knownvalue.StringRegexp(regexp.MustCompile(`^.+:billing-usage-summary$`)),
+						),
+						statecheck.ExpectKnownValue("data.github_enterprise_billing_usage_summary.test",
+							tfjsonpath.New("usage_items"),
+							knownvalue.NotNull(),
+						),
+						statecheck.ExpectKnownValue("data.github_enterprise_billing_usage_summary.test",
+							tfjsonpath.New("time_period"),
+							knownvalue.NotNull(),
+						),
 					},
 				},
 			},
@@ -55,6 +68,14 @@ func TestAccGithubEnterpriseBillingUsageSummary(t *testing.T) {
 							tfjsonpath.New("enterprise_slug"),
 							knownvalue.StringExact(testAccConf.enterpriseSlug),
 						),
+						statecheck.ExpectKnownValue("data.github_enterprise_billing_usage_summary.test",
+							tfjsonpath.New("usage_items"),
+							knownvalue.NotNull(),
+						),
+						statecheck.ExpectKnownValue("data.github_enterprise_billing_usage_summary.test",
+							tfjsonpath.New("time_period"),
+							knownvalue.NotNull(),
+						),
 					},
 				},
 			},

github/data_source_github_enterprise_billing_usage_test.go

@@ -2,6 +2,7 @@ package github
 
 import (
 	"fmt"
+	"regexp"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
@@ -29,6 +30,14 @@ func TestAccGithubEnterpriseBillingUsage(t *testing.T) {
 							tfjsonpath.New("enterprise_slug"),
 							knownvalue.StringExact(testAccConf.enterpriseSlug),
 						),
+						statecheck.ExpectKnownValue("data.github_enterprise_billing_usage.test",
+							tfjsonpath.New("id"),
+							knownvalue.StringRegexp(regexp.MustCompile(`^.+:billing-usage$`)),
+						),
+						statecheck.ExpectKnownValue("data.github_enterprise_billing_usage.test",
+							tfjsonpath.New("usage_items"),
+							knownvalue.NotNull(),
+						),
 					},
 				},
 			},
@@ -54,6 +63,40 @@ func TestAccGithubEnterpriseBillingUsage(t *testing.T) {
 							tfjsonpath.New("enterprise_slug"),
 							knownvalue.StringExact(testAccConf.enterpriseSlug),
 						),
+						statecheck.ExpectKnownValue("data.github_enterprise_billing_usage.test",
+							tfjsonpath.New("usage_items"),
+							knownvalue.NotNull(),
+						),
+					},
+				},
+			},
+		})
+	})
+
+	t.Run("reads billing usage with month filter without error", func(t *testing.T) {
+		config := fmt.Sprintf(`
+			data "github_enterprise_billing_usage" "test" {
+				enterprise_slug = "%s"
+				year            = 2025
+				month           = 1
+			}
+		`, testAccConf.enterpriseSlug)
+
+		resource.Test(t, resource.TestCase{
+			PreCheck:          func() { skipUnlessMode(t, enterprise) },
+			ProviderFactories: providerFactories,
+			Steps: []resource.TestStep{
+				{
+					Config: config,
+					ConfigStateChecks: []statecheck.StateCheck{
+						statecheck.ExpectKnownValue("data.github_enterprise_billing_usage.test",
+							tfjsonpath.New("enterprise_slug"),
+							knownvalue.StringExact(testAccConf.enterpriseSlug),
+						),
+						statecheck.ExpectKnownValue("data.github_enterprise_billing_usage.test",
+							tfjsonpath.New("usage_items"),
+							knownvalue.NotNull(),
+						),
 					},
 				},
 			},