fix: update go-github dependency to v84 and improve source handling in repository property conditions

Author: Ravio1i

github/resource_github_enterprise_ruleset.go

@@ -7,7 +7,7 @@ import (
 	"net/http"
 	"strconv"
 
-	"github.com/google/go-github/v82/github"
+	"github.com/google/go-github/v84/github"
 	"github.com/hashicorp/terraform-plugin-log/tflog"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"

github/util_rules.go

@@ -322,9 +322,13 @@ func expandRepositoryPropertyConditions(v []any) *github.RepositoryRulesetReposi
 					propertyValues = append(propertyValues, pv.(string))
 				}
 			}
+			var source *string
+			if s := propertyMap["source"].(string); s != "" {
+				source = &s
+			}
 			property := &github.RepositoryRulesetRepositoryPropertyTargetParameters{
 				Name:           propertyMap["name"].(string),
-				Source:         new(propertyMap["source"].(string)),
+				Source:         source,
 				PropertyValues: propertyValues,
 			}
 			include = append(include, property)
@@ -340,9 +344,13 @@ func expandRepositoryPropertyConditions(v []any) *github.RepositoryRulesetReposi
 					propertyValues = append(propertyValues, pv.(string))
 				}
 			}
+			var source *string
+			if s := propertyMap["source"].(string); s != "" {
+				source = &s
+			}
 			property := &github.RepositoryRulesetRepositoryPropertyTargetParameters{
 				Name:           propertyMap["name"].(string),
-				Source:         new(propertyMap["source"].(string)),
+				Source:         source,
 				PropertyValues: propertyValues,
 			}
 			exclude = append(exclude, property)

github/util_rules_test.go

@@ -1498,7 +1498,7 @@ func TestFlattenConditionsRepositoryProperty(t *testing.T) {
 		},
 	}
 
-	result := flattenConditions(context.Background(), conditions, RulesetLevelEnterprise)
+	result := flattenConditions(t.Context(), conditions, RulesetLevelEnterprise)
 
 	if len(result) != 1 {
 		t.Fatalf("Expected 1 element in result, got %d", len(result))
@@ -1568,7 +1568,7 @@ func TestRoundTripConditionsRepositoryProperty(t *testing.T) {
 		t.Fatal("Expected expanded conditions to not be nil")
 	}
 
-	flattened := flattenConditions(context.Background(), expanded, RulesetLevelEnterprise)
+	flattened := flattenConditions(t.Context(), expanded, RulesetLevelEnterprise)
 	if len(flattened) != 1 {
 		t.Fatalf("Expected 1 flattened result, got %d", len(flattened))
 	}