Fix github_branch_protection migration test to be a unit test

Signed-off-by: Timo Sand <timo.sand@f-secure.com>

Author: deiga

github/resource_github_branch_protection_migration_test.go

@@ -0,0 +1,35 @@
+package github
+
+import (
+	"reflect"
+	"testing"
+)
+
+func testGithubBranchProtectionStateDataV1() map[string]any {
+	return map[string]any{
+		"blocks_creations":  true,
+		"push_restrictions": [...]string{"/example-user"},
+	}
+}
+
+func testGithubBranchProtectionStateDataV2() map[string]any {
+	restrictions := []any{map[string]any{
+		"blocks_creations": true,
+		"push_allowances":  [...]string{"/example-user"},
+	}}
+	return map[string]any{
+		"restrict_pushes": restrictions,
+	}
+}
+
+func Test_resourceGithubBranchProtectionStateUpgradeV1(t *testing.T) {
+	expected := testGithubBranchProtectionStateDataV2()
+	actual, err := resourceGithubBranchProtectionUpgradeV1(t.Context(), testGithubBranchProtectionStateDataV1(), nil)
+	if err != nil {
+		t.Fatalf("error migrating state: %s", err)
+	}
+
+	if !reflect.DeepEqual(expected, actual) {
+		t.Fatalf("\n\nexpected:\n\n%#v\n\ngot:\n\n%#v\n\n", expected, actual)
+	}
+}

github/resource_github_branch_protection_test.go

@@ -1,9 +1,7 @@
 package github
 
 import (
-	"context"
 	"fmt"
-	"reflect"
 	"regexp"
 	"testing"
 
@@ -749,32 +747,3 @@ func importBranchProtectionByRepoID(repoLogicalName, pattern string) resource.Im
 		return fmt.Sprintf("%s:%s", repoID, pattern), nil
 	}
 }
-
-func testGithubBranchProtectionStateDataV1() map[string]any {
-	return map[string]any{
-		"blocks_creations":  true,
-		"push_restrictions": [...]string{"/example-user"},
-	}
-}
-
-func testGithubBranchProtectionStateDataV2() map[string]any {
-	restrictions := []any{map[string]any{
-		"blocks_creations": true,
-		"push_allowances":  [...]string{"/example-user"},
-	}}
-	return map[string]any{
-		"restrict_pushes": restrictions,
-	}
-}
-
-func TestAccGithubBranchProtectionV4StateUpgradeV1(t *testing.T) {
-	expected := testGithubBranchProtectionStateDataV2()
-	actual, err := resourceGithubBranchProtectionUpgradeV1(context.Background(), testGithubBranchProtectionStateDataV1(), nil)
-	if err != nil {
-		t.Fatalf("error migrating state: %s", err)
-	}
-
-	if !reflect.DeepEqual(expected, actual) {
-		t.Fatalf("\n\nexpected:\n\n%#v\n\ngot:\n\n%#v\n\n", expected, actual)
-	}
-}