feat: add github_user_ssh_signing_key by simonostendorf · Pull Request #2366 · integrations/terraform-provider-github

simonostendorf · 2024-08-26T01:24:21Z

Resolves #2365

Resolves #1917

Before the change?

managing ssh signing keys was not possible

After the change?

managing ssh signing keys is possible with github_user_ssh_signing_key resource
the resource is equal to the existing github_user_ssh_key resource that manages ssh auth keys

Pull request checklist

Tests for the changes have been added (for bug fixes / features)
Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

Yes
No

kfcampbell · 2024-08-30T20:32:06Z

@simonostendorf can you please link to the new doc you created in the github.erb file so it's discoverable?

simonostendorf · 2024-08-31T06:46:29Z

@simonostendorf can you please link to the new doc you created in the github.erb file so it's discoverable?

@kfcampbell sorry forgot that. I added it now.

quotidian-ennui · 2024-10-16T09:04:30Z

#1917 should perhaps be formally linked to this PR as well since it appears equivalent to #2365

simonostendorf · 2025-05-28T05:38:59Z

@kfcampbell hey, can we get this merged?

kilianpaquier · 2025-10-10T18:34:56Z

Would love to see this merged

github/resource_github_user_ssh_signing_key.go

deiga · 2026-01-17T19:31:21Z

Hey @simonostendorf
Sorry that you have needed to wait for so long. Could you rebase your branch and adjust your code to fit our newer standards?

Use Contex-aware functions: [MAINT] Migrate all resources and data sources to Context-aware CRUD functions #2996
Use tflog for logging: [MAINT] Tracking issue for refactoring logging to use tflog instead of log #3070
Adhere to new testing structure

simonostendorf · 2026-01-18T05:48:31Z

Hey @simonostendorf Sorry that you have needed to wait for so long. Could you rebase your branch and adjust your code to fit our newer standards?

Use Contex-aware functions: [MAINT] Migrate all resources and data sources to Context-aware CRUD functions #2996

Use tflog for logging: [MAINT] Tracking issue for refactoring logging to use tflog instead of log #3070

Adhere to new testing structure

Should be implemented now

github/resource_github_user_ssh_signing_key.go

github/resource_github_user_ssh_signing_key_test.go

github/resource_github_user_ssh_signing_key.go

github/resource_github_user_ssh_signing_key_test.go

stevehipwell · 2026-02-18T10:20:27Z

How can I update the website? When I run make website terraform-website downloads and fails because a unknown makefile target is called.

@simonostendorf you just manually modify the website files, check some previous PRs to see how it was done.

simonostendorf · 2026-02-18T19:41:36Z

Everything should be fixed now (hopefully) :D

stevehipwell · 2026-02-23T10:44:48Z

@simonostendorf it looks like you've got a conflict, could you please fix this before I give it a review?

simonostendorf · 2026-02-23T20:50:38Z

@simonostendorf it looks like you've got a conflict, could you please fix this before I give it a review?

@stevehipwell fixed :)

stevehipwell · 2026-02-24T11:42:49Z

@simonostendorf could you please fix the lint errors.

simonostendorf · 2026-02-24T14:46:39Z

@simonostendorf could you please fix the lint errors.

Should be fixed now :)

stevehipwell · 2026-02-24T17:31:47Z

@simonostendorf please take a look at the sweep failure.

simonostendorf · 2026-02-24T19:04:01Z

@simonostendorf please take a look at the sweep failure.

@stevehipwell Got the wrong package as import in my test file and therefore the sweep redefined error occured. Should be fixed now "make test" runs fine locally.

stevehipwell

LGTM

github/resource_github_user_ssh_key.go

github/resource_github_user_ssh_signing_key.go

github/resource_github_user_ssh_key.go

simonostendorf · 2026-03-16T22:29:31Z

I only wanted to say that I havent got much time this and the next week and will fix the comments here later.

github/resource_github_user_ssh_key.go

github/resource_github_user_ssh_key_migration.go

github/resource_github_user_ssh_signing_key.go

github/resource_github_user_ssh_signing_key_test.go

website/docs/r/user_ssh_key.html.markdown

website/docs/r/user_ssh_signing_key.html.markdown

website/docs/r/user_ssh_key.html.markdown

github/resource_github_user_ssh_signing_key.go

github/resource_github_user_ssh_key_migration.go

feat: add docs for github_user_ssh_signing_key fix: add github_user_ssh_signing_key to provider.go fix: add github_user_ssh_signing_key to github.erb fix: use tflog, context, test-structure fix: use resource-prefix, sweeper, 404-handling, direct read fix: key_id feat: import feat: adjust user_ssh_key to new structure fix: typo fix: dont overwrite key on create fix: add new fields to website

simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from 875d76f to 1dde54f Compare September 15, 2024 08:06

simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from f5d9e6d to 3860cf3 Compare September 22, 2024 16:20

simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from 065e10e to efcc88e Compare September 28, 2024 15:22

simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from 009fd4b to 4713629 Compare October 10, 2024 11:42

simonostendorf force-pushed the feat/github_user_ssh_signing_key branch from 4713629 to 8087453 Compare October 16, 2024 09:17

simonostendorf force-pushed the feat/github_user_ssh_signing_key branch from 8087453 to dd6de65 Compare May 28, 2025 05:38

deiga requested changes Jan 17, 2026

View reviewed changes

github/resource_github_user_ssh_signing_key.go Outdated Show resolved Hide resolved

github-project-automation bot moved this from 🛑 Blocked/Awaiting Response to 🏗 In progress in 🧰 Octokit Active Jan 17, 2026

simonostendorf mentioned this pull request Jan 18, 2026

add difference of auth and signing keys to github_user_ssh_key #2365

Open

1 task

simonostendorf force-pushed the feat/github_user_ssh_signing_key branch from dd6de65 to 171470e Compare January 18, 2026 05:46

github-actions bot added the Type: Feature New feature or request label Jan 18, 2026

deiga requested changes Jan 22, 2026

View reviewed changes

github/resource_github_user_ssh_signing_key.go Outdated Show resolved Hide resolved

github/resource_github_user_ssh_signing_key.go Outdated Show resolved Hide resolved

github/resource_github_user_ssh_signing_key_test.go Outdated Show resolved Hide resolved

deiga added the New resource label Jan 22, 2026

simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from 78de3d9 to fcd48d3 Compare January 22, 2026 22:21

simonostendorf force-pushed the feat/github_user_ssh_signing_key branch from fcd48d3 to 07dd337 Compare February 4, 2026 21:18

deiga requested changes Feb 9, 2026

View reviewed changes

simonostendorf force-pushed the feat/github_user_ssh_signing_key branch 2 times, most recently from a74c9d4 to d06ac7d Compare February 10, 2026 14:05

simonostendorf force-pushed the feat/github_user_ssh_signing_key branch from f71b438 to 258ae05 Compare February 18, 2026 19:41

simonostendorf force-pushed the feat/github_user_ssh_signing_key branch from 258ae05 to d855d9d Compare February 23, 2026 20:49

simonostendorf requested a review from stevehipwell February 23, 2026 20:50

stevehipwell previously approved these changes Mar 2, 2026

View reviewed changes

robert-crandall reviewed Mar 13, 2026

View reviewed changes

github/resource_github_user_ssh_key.go Show resolved Hide resolved

github/resource_github_user_ssh_key.go Outdated Show resolved Hide resolved

github/resource_github_user_ssh_key.go Outdated Show resolved Hide resolved

github/resource_github_user_ssh_signing_key.go Show resolved Hide resolved

simonostendorf dismissed stevehipwell’s stale review via 4db92ca March 15, 2026 08:10

deiga requested changes Mar 15, 2026

View reviewed changes

simonostendorf force-pushed the feat/github_user_ssh_signing_key branch from 4db92ca to c550631 Compare March 23, 2026 20:08

deiga requested changes Mar 25, 2026

View reviewed changes

simonostendorf force-pushed the feat/github_user_ssh_signing_key branch from c550631 to 37ced99 Compare March 25, 2026 20:43

deiga requested changes Mar 25, 2026

View reviewed changes

simonostendorf added 8 commits April 13, 2026 07:25

fix: linting

a70a32e

fix(tests): correct imports

596ca30

fix: int usage, keep url, state migration

6315933

fix: readd url

814cff9

fix: docs, unneeded args, missing description

e3d891e

fix: use deleteResourceOn404AndSwallow304OtherwiseReturnError

3fa41d6

fix: setting key_id, schemaVersion, website arguments

8b9f2ca

simonostendorf force-pushed the feat/github_user_ssh_signing_key branch from 1917580 to 8b9f2ca Compare April 13, 2026 05:25

deiga added this to the v6.13.0 Release milestone Apr 14, 2026

Conversation

simonostendorf commented Aug 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before the change?

After the change?

Pull request checklist

Does this introduce a breaking change?

Uh oh!

kfcampbell commented Aug 30, 2024

Uh oh!

simonostendorf commented Aug 31, 2024

Uh oh!

quotidian-ennui commented Oct 16, 2024

Uh oh!

simonostendorf commented May 28, 2025

Uh oh!

kilianpaquier commented Oct 10, 2025

Uh oh!

Uh oh!

deiga commented Jan 17, 2026

Uh oh!

simonostendorf commented Jan 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stevehipwell commented Feb 18, 2026

Uh oh!

simonostendorf commented Feb 18, 2026

Uh oh!

stevehipwell commented Feb 23, 2026

Uh oh!

simonostendorf commented Feb 23, 2026

Uh oh!

stevehipwell commented Feb 24, 2026

Uh oh!

simonostendorf commented Feb 24, 2026

Uh oh!

stevehipwell commented Feb 24, 2026

Uh oh!

simonostendorf commented Feb 24, 2026

Uh oh!

stevehipwell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

simonostendorf commented Mar 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

simonostendorf commented Aug 26, 2024 •

edited

Loading