Skip to content

Feat: add team notification setting#2455

Closed
Nepoxx wants to merge 4 commits intointegrations:mainfrom
Nepoxx:feat/add-team-notification-setting
Closed

Feat: add team notification setting#2455
Nepoxx wants to merge 4 commits intointegrations:mainfrom
Nepoxx:feat/add-team-notification-setting

Conversation

@Nepoxx
Copy link
Copy Markdown

@Nepoxx Nepoxx commented Nov 7, 2024

Resolves #2454

Before the change?

  • Team notification setting could not be changed

After the change?

  • Team notification setting can be changed

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Depends on #2443

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 5, 2025

👋 Hey Friends, this pull request has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions Bot added the Status: Stale Used by stalebot to clean house label Aug 5, 2025
Nepoxx and others added 2 commits August 6, 2025 08:47
- Add resource tests covering default, enabled, and disabled notification settings
- Add data source tests verifying notification_setting is properly exposed
- Include update scenarios to test field mutability
@Nepoxx Nepoxx force-pushed the feat/add-team-notification-setting branch from 02a312a to cf6caf2 Compare August 6, 2025 13:03
@Nepoxx
Copy link
Copy Markdown
Author

Nepoxx commented Aug 6, 2025

PR is still relevant.

@Nepoxx Nepoxx changed the title Feat/add team notification setting Feat: add team notification setting Aug 6, 2025
@github-actions github-actions Bot removed the Status: Stale Used by stalebot to clean house label Aug 7, 2025
@stevehipwell
Copy link
Copy Markdown
Collaborator

stevehipwell commented Jan 19, 2026

This functionality was implemented in #2863.

@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in 🧰 Octokit Active Jan 19, 2026
@Nepoxx
Copy link
Copy Markdown
Author

Nepoxx commented Jan 19, 2026

@stevehipwell I fail to see how that PR implements the notifications settings?

@stevehipwell
Copy link
Copy Markdown
Collaborator

Sorry should have been #3059, on mobile app.

@Nepoxx Nepoxx deleted the feat/add-team-notification-setting branch January 19, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: Support team notification setting

2 participants