feat: add github_enterprise_actions_hosted_runner by nico34638 · Pull Request #3017 · integrations/terraform-provider-github

nico34638 · 2025-12-22T13:46:24Z

Resolves #3016

Before the change?

No possibility to create hosted runner at enterprise level

After the change?

It's possible

Pull request checklist

Schema migrations have been created if needed (example)
Tests for the changes have been added (for bug fixes / features)
Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

Yes
No

github-actions · 2025-12-22T13:46:33Z

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

deiga · 2025-12-24T22:58:46Z

Hey @nico34638 👋

Thank you very much for your contribution! We're currently working on a major release of the provider and that will possibly delay getting this PR merged.

While that's happening, could I bother you for a few changes?

We're moving towards using Context-aware provider functions (ReadContext, CreateContext, etc.). Could you refactor your PR to use those? :)
Another major upcoming change will be generating docs based on Schema contents. Could you ensure that all levels of the Schema have Description fields which contain all necessary information for the docs?

Support for Hosted runners for enterprises was added in v70 of go-github. Our upcoming major release will upgrade to v77. Could you rebase your branch on top of #2891 and use the SDK methods instead of manual HTTP requests? :)

nico34638 · 2025-12-25T10:26:36Z

Okay, I made the changes you requested. I rebased on your branch with go github/v77 and changed the description fields. Is that okay with you? I tested it, and with the changes, it still works.

deiga · 2026-01-09T23:00:13Z

Hey @nico34638
Could you rebase your PR onto main now, we've upgraded the go-github version? 🙏

nico34638 · 2026-01-10T09:04:39Z

Hey @deiga, It's done. Do you have any idea when the provider's next release will be?

deiga

Please ensure the test structure follows the current pattern

nico34638 · 2026-01-17T14:28:08Z

I have corrected the comments

nico34638 · 2026-01-21T06:35:09Z

Hi @deiga do you any news ?

stevehipwell

Thanks for the PR @nico34638, I've added some initial review comments.

nico34638 · 2026-02-04T14:50:38Z

Following the last review, I'm taking this opportunity to add two data sources for hosted enterprise runners:
one to list them and one to get the details.

nico34638 · 2026-02-09T10:16:10Z

Hi @stevehipwell @deiga Do you have any news ?

deiga

Please ensure to propagate comments to other places where they would be applicable

deiga

Please read through your own code and see to it that it's consistent with itself.

I don't know if you use an LLM to generate code or are just in a hurry, but please don't make us comment multiple times on the same issues ☺️

nico34638 · 2026-02-14T16:39:19Z

Thanks for the feedback. I apologize for the inconsistencies.

I am really trying my best to keep this PR clean, but it is not that simple. Reviews are spaced about many weeks apart. It is hard to keep track of comments made two months ago.

The requirements also keep changing mid-flight. For example, we now need datasources in addition to resources to get merged. On top of that, the codebase is being refactored.

I have reviewed the code again and updated a few more details on my end. However, I would really appreciate more specific information on what exactly still needs to change

deiga

Partial review

deiga · 2026-03-10T20:27:23Z

+			"size": {
+				Type:        schema.TypeString,
+				Required:    true,
+				Description: "Machine size for the hosted runner (e.g., '4-core', '8-core'). This determines the CPU, memory, and storage resources allocated to the runner. Can be updated to scale the runner. To list available sizes, use the GitHub API: GET /enterprises/{enterprise}/actions/hosted-runners/machine-sizes.",


question: would this benefit from having a validation that the string ends in <number>-core?

I don't think that's necessary, the API error is already clear.

But validation happens before API call, which means less wasted rate limit usage

I had regex validation

deiga

Partial review

deiga · 2026-03-31T17:34:21Z

+		`, testAccConf.enterpriseSlug, testResourcePrefix, randomID, testResourcePrefix, randomID)
+
+		resource.Test(t, resource.TestCase{
+			PreCheck:          func() { skipUnlessMode(t, enterprise) },


Suggested change

PreCheck: func() { skipUnlessMode(t, enterprise) },

PreCheck: func() { skipUnlessEnterprise(t) },

deiga · 2026-03-31T17:35:23Z

+
+func dataSourceGithubEnterpriseActionsHostedRunner() *schema.Resource {
+	return &schema.Resource{
+		ReadContext: dataSourceGithubEnterpriseActionsHostedRunnerRead,


Please add a top-level Description

deiga · 2026-03-31T17:37:44Z

+	runnerData := map[string]any{
+		"name":                 runner.GetName(),
+		"runner_group_id":      int(runner.GetRunnerGroupID()),
+		"platform":             runner.GetPlatform(),
+		"status":               runner.GetStatus(),
+		"maximum_runners":      int(runner.GetMaximumRunners()),
+		"public_ip_enabled":    runner.GetPublicIPEnabled(),
+		"image_details":        flattenHostedRunnerImage(runner.ImageDetails),
+		"machine_size_details": flattenHostedRunnerMachineSpec(runner.MachineSizeDetails),
+		"public_ips":           flattenHostedRunnerPublicIPs(runner.PublicIPs),
+	}
+
+	if runner.LastActiveOn != nil {
+		runnerData["last_active_on"] = runner.LastActiveOn.Format(time.RFC3339)
+	}
+
+	for k, v := range runnerData {
+		if err := d.Set(k, v); err != nil {
+			return diag.FromErr(err)
+		}
+	}


issue: Please simplify this structure to just use d.Set without this map. This does not improve clarity, nor does it win us anything

deiga · 2026-03-31T17:37:53Z

+
+func dataSourceGithubEnterpriseActionsHostedRunners() *schema.Resource {
+	return &schema.Resource{
+		ReadContext: dataSourceGithubEnterpriseActionsHostedRunnersRead,


Please add a top-level Description

deiga · 2026-03-31T17:40:29Z

+			Delete: schema.DefaultTimeout(15 * time.Minute),
+		},
+
+		Schema: map[string]*schema.Schema{


Please add a top-level Description

deiga · 2026-03-31T17:52:15Z

+		return diag.Errorf("error updating enterprise hosted runner: %s", err.Error())
+	}
+
+	return resourceGithubEnterpriseActionsHostedRunnerRead(ctx, d, meta)


Never call any CRUD functions in any part of the code

Suggested change

return resourceGithubEnterpriseActionsHostedRunnerRead(ctx, d, meta)

return nil

deiga · 2026-03-31T17:52:22Z

+	enterpriseSlug, runnerIDStr, err := parseID2(d.Id())
+	if err != nil {
+		return diag.FromErr(err)
+	}
+
+	runnerID, err := strconv.ParseInt(runnerIDStr, 10, 64)
+	if err != nil {
+		return diag.Errorf("invalid runner ID %q: %s", runnerIDStr, err.Error())
+	}


issue: both fields exists in State already, there should be no need to have parsing code here

deiga · 2026-03-31T17:53:44Z

+			}
+		`, testAccConf.enterpriseSlug, randomID, randomID)
+
+		configUpdated := fmt.Sprintf(`


Use only one template string and fmt.Sprintf to build the config

deiga · 2026-03-31T17:55:39Z

+		return nil
+	}
+
+	imageMap := imageList[0].(map[string]any)


Please add some explanation why we are only accessing the first item.

deiga · 2026-03-31T17:55:50Z

These functions are missing tests, please add them

nico34638 force-pushed the main branch from 1cef42c to f0c3d2d Compare December 25, 2025 10:22

nico34638 force-pushed the main branch from f0c3d2d to 1705f92 Compare January 10, 2026 09:02

deiga requested changes Jan 10, 2026

View reviewed changes

deiga requested changes Jan 11, 2026

View reviewed changes

Comment thread github/resource_github_enterprise_actions_hosted_runner_test.go Outdated

Comment thread github/resource_github_enterprise_actions_hosted_runner_test.go Outdated

Comment thread github/resource_github_enterprise_actions_hosted_runner_test.go Outdated

nico34638 force-pushed the main branch from 29a447b to 72f238a Compare January 13, 2026 18:05

deiga requested changes Jan 13, 2026

View reviewed changes

nico34638 force-pushed the main branch 3 times, most recently from 36951d4 to 9ac9b53 Compare January 17, 2026 14:27

nico34638 force-pushed the main branch from 9ac9b53 to 79f179f Compare January 21, 2026 06:35

deiga approved these changes Jan 21, 2026

View reviewed changes

deiga added this to the v6.11.0 Release milestone Jan 21, 2026

deiga added Type: Feature New feature or request New resource labels Jan 21, 2026

stevehipwell requested changes Feb 3, 2026

View reviewed changes

stevehipwell modified the milestones: v6.11.0 Release, v6.12.0 Release Feb 3, 2026

nico34638 force-pushed the main branch from 79f179f to 59cb1cb Compare February 4, 2026 09:12

nico34638 force-pushed the main branch from a62bc4d to badfeea Compare February 4, 2026 14:51

nico34638 requested a review from stevehipwell February 5, 2026 11:29

nico34638 force-pushed the main branch from badfeea to 64ac068 Compare February 9, 2026 11:27

deiga requested changes Feb 14, 2026

View reviewed changes

nico34638 force-pushed the main branch 3 times, most recently from 06b9a9c to 54d4fbe Compare February 14, 2026 13:19

deiga requested changes Feb 14, 2026

View reviewed changes

nico34638 force-pushed the main branch from 54d4fbe to 195951f Compare February 14, 2026 16:38

deiga mentioned this pull request Mar 4, 2026

[FEAT]: github_enterprise_actions_runner_group / github_actions_runner_group - Support network configuration #2302

Open

1 task

nico34638 force-pushed the main branch from 195951f to e952764 Compare March 5, 2026 16:17

deiga requested changes Mar 10, 2026

View reviewed changes

nico34638 and others added 5 commits March 17, 2026 11:54

feat: add github_enterprise_actions_hosted_runner

6eff8d0

fix: review for github_enterprise_actions_hosted_runner

f753072

github: add data source enterprise_actions_hosted_runner

16b5787

data_source hosted runner: fix review

c48fddf

resource_github_enterprise_actions_hosted_runner: fix review

3b2f0f6

nico34638 force-pushed the main branch 2 times, most recently from faa7c93 to 4572819 Compare March 17, 2026 13:58

apply review and migrate to new test framework

8745401

nico34638 force-pushed the main branch from 4572819 to 8745401 Compare March 17, 2026 16:46

deiga requested changes Apr 14, 2026

View reviewed changes

deiga modified the milestones: v6.12.0 Release, v6.13.0 Release Apr 14, 2026

	PreCheck: func() { skipUnlessMode(t, enterprise) },
	PreCheck: func() { skipUnlessEnterprise(t) },

	return resourceGithubEnterpriseActionsHostedRunnerRead(ctx, d, meta)
	return nil

Conversation

nico34638 commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before the change?

After the change?

Pull request checklist

Does this introduce a breaking change?

Uh oh!

github-actions Bot commented Dec 22, 2025

Uh oh!

deiga commented Dec 24, 2025

Uh oh!

nico34638 commented Dec 25, 2025

Uh oh!

deiga commented Jan 9, 2026

Uh oh!

nico34638 commented Jan 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deiga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nico34638 commented Jan 17, 2026

Uh oh!

nico34638 commented Jan 21, 2026

Uh oh!

stevehipwell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nico34638 commented Feb 4, 2026

Uh oh!

nico34638 commented Feb 9, 2026

Uh oh!

deiga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deiga left a comment

Choose a reason for hiding this comment

Uh oh!

nico34638 commented Feb 14, 2026

Uh oh!

deiga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nico34638 commented Dec 22, 2025 •

edited

Loading