[MAINT] Improve provider tests#3061
Conversation
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
…the same time Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
This looks good. It might be worth adding support for app auth via env variable? This is something we require to better be able to run integration tests.
stevehipwell
added
the
Type: Maintenance
|
@stevehipwell Yeah, that could be good, but I don't think it's best to do in this PR. There is an open Feature request for that as well |
* Ensure that `token` is never configured together with `app_auth` Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Add test to verify that `GITHUB_TOKEN` and `app_auth` are not set at the same time Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Ensure `max_per_page` test actually runs Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Ensure `max_retries` is actually tested Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Fix indentation Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Use `ExactlyOneOf` instead of `ConflictsWith` Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Add some more infor logging Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Fix brackets Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Update Org test to ensure it actually tests Signed-off-by: Timo Sand <timo.sand@f-secure.com> --------- Signed-off-by: Timo Sand <timo.sand@f-secure.com>
3 participants
Supersedes #3033
Before the change?
tokenandapp_authat the same timeAfter the change?
token(orGITHUB_TOKEN) andapp_authcan't be set at the same timePull request checklist
Schema migrations have been created if needed (example)Does this introduce a breaking change?
Please see our docs on breaking changes to help!