feat: Fixup repository environment logic#3162
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
4d860a2 to
0519dda
Compare
0519dda to
6798857
Compare
6798857 to
80a15b8
Compare
|
@deiga this is ready for a re-review. I've made the most of your testing improvements. I also have thoughts around the use of |
80a15b8 to
10e5e6b
Compare
|
@deiga thanks for the |
7c8fb21 to
ac4fdb7
Compare
11cfeca to
a9e830f
Compare
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
a9e830f to
eea55f5
Compare
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Resolves #ISSUE_NUMBER
Before the change?
github_repository_environmentresource logic for reviewers had incorrect constraintsgithub_repository_environment_deployment_policyresource missing policy ID attributeAfter the change?
github_repository_environmenthas correct constraints for reviewers, including validation for the sum of users and teamsgithub_repository_environment_deployment_policyhas newpolicy_idattributerepository_idPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!