Skip to content

[MAINT] Fix test of Org Repo Roles#3193

Merged
stevehipwell merged 6 commits intointegrations:mainfrom
F-Secure-web:fix-org-repo-roles
Feb 20, 2026
Merged

[MAINT] Fix test of Org Repo Roles#3193
stevehipwell merged 6 commits intointegrations:mainfrom
F-Secure-web:fix-org-repo-roles

Conversation

@deiga
Copy link
Copy Markdown
Collaborator

@deiga deiga commented Feb 14, 2026


Before the change?

  • Computed fields were not being set correctly in resource_github_organization_repository_role
  • Tests for resource_github_organization_repository_role were failing due to configuration issues
  • TODO comments for github_organization_repository_role about upgrading to v68+

After the change?

  • Corrected behaviour of Computed fields
  • Fixed tests
  • Added validation for the permissions field in. resource_github_organization_repository_role
  • Update to use new SDK functions

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@github-actions github-actions Bot added the Type: Bug Something isn't working as documented label Feb 14, 2026
@deiga deiga added this to the v6.12.0 Release milestone Feb 14, 2026
@deiga deiga added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Feb 14, 2026
Comment thread github/resource_github_organization_repository_role.go Outdated
@deiga deiga force-pushed the fix-org-repo-roles branch from ed6d93b to 56be007 Compare February 16, 2026 18:45
@deiga deiga requested a review from stevehipwell February 16, 2026 18:45
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deiga thanks for fixing these, I'm not sure how I managed to miss setting the repo_role. I'll get the API for listing the roles into the SDK, but with the current provider implementation I think we probably want to keep it static and use go generate to keep it up-to-date (my docs PR uses go generate so it should be straightforward to extend it for this an other potential uses.

@deiga deiga force-pushed the fix-org-repo-roles branch from 56be007 to 8058dbd Compare February 17, 2026 20:56
@stevehipwell stevehipwell enabled auto-merge (squash) February 20, 2026 10:11
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
auto-merge was automatically disabled February 20, 2026 10:25

Head branch was pushed to by a user without write access

@deiga deiga force-pushed the fix-org-repo-roles branch from 8058dbd to fc61a07 Compare February 20, 2026 10:25
@stevehipwell stevehipwell merged commit 3063ca4 into integrations:main Feb 20, 2026
11 of 14 checks passed
JiayangZhou pushed a commit to JiayangZhou/terraform-provider-github that referenced this pull request Apr 16, 2026
* Fix missing Set of Computed field in Org Repo Role

Signed-off-by: Timo Sand <timo.sand@f-secure.com>

* Ensure tests are configured correctly

Signed-off-by: Timo Sand <timo.sand@f-secure.com>

* Add validation of `permissions` values

Signed-off-by: Timo Sand <timo.sand@f-secure.com>

* Update to use new SDK methods

Signed-off-by: Timo Sand <timo.sand@f-secure.com>

* Update DS to use new SDK methods

Signed-off-by: Timo Sand <timo.sand@f-secure.com>

* Remove unnecessary  `d.Set("role_id")`

Signed-off-by: Timo Sand <timo.sand@f-secure.com>

---------

Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as documented Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants