[MAINT] Fix test of Org Repo Roles#3193
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
ed6d93b to
56be007
Compare
stevehipwell
left a comment
There was a problem hiding this comment.
LGTM
@deiga thanks for fixing these, I'm not sure how I managed to miss setting the repo_role. I'll get the API for listing the roles into the SDK, but with the current provider implementation I think we probably want to keep it static and use go generate to keep it up-to-date (my docs PR uses go generate so it should be straightforward to extend it for this an other potential uses.
56be007 to
8058dbd
Compare
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Head branch was pushed to by a user without write access
8058dbd to
fc61a07
Compare
* Fix missing Set of Computed field in Org Repo Role
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
* Ensure tests are configured correctly
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
* Add validation of `permissions` values
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
* Update to use new SDK methods
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
* Update DS to use new SDK methods
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
* Remove unnecessary `d.Set("role_id")`
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
---------
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Before the change?
resource_github_organization_repository_roleresource_github_organization_repository_rolewere failing due to configuration issuesgithub_organization_repository_roleabout upgrading to v68+After the change?
permissionsfield in.resource_github_organization_repository_rolePull request checklist
Schema migrations have been created if needed (example)Does this introduce a breaking change?
Please see our docs on breaking changes to help!