[MAINT] Convert all usage of deprecated ValidateFunc to ValidateDiagFunc#3195
Merged
stevehipwell merged 7 commits intointegrations:mainfrom Feb 20, 2026
Merged
Conversation
deiga
changed the title
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
deiga
added
Deprecation
Type: Maintenance
deiga
force-pushed
the
validatefunc-cleanup
branch
from
06d6dd4 to
e487d8f
Compare
stevehipwell
approved these changes
Feb 16, 2026
Collaborator
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
LGTM
@deiga could you please rebase this?
deiga
force-pushed
the
validatefunc-cleanup
branch
from
e487d8f to
e19484e
Compare
Collaborator
Author
|
@stevehipwell Done |
deiga
force-pushed
the
validatefunc-cleanup
branch
from
e19484e to
e431203
Compare
nickfloyd
approved these changes
Feb 18, 2026
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
deiga
force-pushed
the
validatefunc-cleanup
branch
from
e431203 to
f05e058
Compare
JiayangZhou
pushed a commit
to JiayangZhou/terraform-provider-github
that referenced
this pull request
Apr 16, 2026
…unc (integrations#3195) * Convert all usage of deprecated `ValidateFunc` to `ValidateDiagFunc` Signed-off-by: Timo Sand <timo.sand@f-secure.com> * replace homebrew `toDiagFunc` with `validation.ToDiagFunc` Signed-off-by: Timo Sand <timo.sand@f-secure.com> * fixup! Correct test after validation simplification Signed-off-by: Timo Sand <timo.sand@f-secure.com> * fixup! Fix GH Tead DS test Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Fix repo test Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Fix failing test Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Remove unnecessary abstraction with `reconfigureVisibility` Signed-off-by: Timo Sand <timo.sand@f-secure.com> --------- Signed-off-by: Timo Sand <timo.sand@f-secure.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the change?
ValidateFunctoDiagFuncfunctionAfter the change?
ValidateDiagFunctoDiagFuncusage has been replaced withvalidation.ToDiagFuncPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!