Add support for EnterpriseOwner#3211
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
|
I don't have a local golang dev environment so I'll have to wait for the CI build before I can test this locally. |
deiga
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I left a few comments
|
Thanks for the changes! Have you been able to run the tests locally? |
Sadly not; setting up a golang dev environment in my company has proven to be a giant pain... |
|
Ran tests locally and they pass on Enterprise. But I think you need to split the tests with |
|
That should be done now. There was an existing test I'm still pretty new to golang but I have managed to get the tests passing locally. |
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: config, | ||
| Check: resource.ComposeTestCheckFunc( |
There was a problem hiding this comment.
Could you refactor this to use ConfigStateChecks instead of Check?
There was a problem hiding this comment.
Could you create a new test for this, instead of changing this existing test and where it can run?
Resolves #3210
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!