Skip to content

[MAINT] Consolidate ID format of github_emu_group_mapping#3215

Merged
stevehipwell merged 7 commits intointegrations:mainfrom
F-Secure-web:consolidate-emu-group-mapping-id
Apr 9, 2026
Merged

[MAINT] Consolidate ID format of github_emu_group_mapping#3215
stevehipwell merged 7 commits intointegrations:mainfrom
F-Secure-web:consolidate-emu-group-mapping-id

Conversation

@deiga
Copy link
Copy Markdown
Collaborator

@deiga deiga commented Feb 21, 2026

Resolves #3200

Before the change?

  • Import ID and Resource ID had different format
  • tflog.SetField was being used incorrectly
  • Tests didn't use terraform-plugin-testing
  • Some tests didn't fully work
  • Docs were missing computed fields

After the change?

  • Import ID and Resource ID have the same format
  • Fixes tflog.SetField usage
  • Updates tests to use terraform-plugin-testing
  • Fixed tests
  • Updates docs

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 21, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@deiga deiga added this to the v6.12.0 Release milestone Feb 21, 2026
@deiga deiga requested a review from stevehipwell February 21, 2026 17:29
stevehipwell
stevehipwell requested changes Feb 23, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good, it's just the discussion about the log context to resolve.

@deiga deiga force-pushed the consolidate-emu-group-mapping-id branch from 3480f37 to 472d4d6 Compare February 23, 2026 18:48
@deiga deiga requested a review from stevehipwell February 23, 2026 18:48
stevehipwell
stevehipwell requested changes Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove a bit more complexity from the logging.

@deiga deiga requested a review from stevehipwell February 24, 2026 19:25
stevehipwell
stevehipwell previously approved these changes Feb 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell
Copy link
Copy Markdown
Collaborator

stevehipwell commented Mar 22, 2026

@deiga could you please rebase this?

@deiga deiga dismissed stale reviews from robert-crandall and stevehipwell via f88c70f March 22, 2026 18:53
@deiga deiga force-pushed the consolidate-emu-group-mapping-id branch from 8977969 to f88c70f Compare March 22, 2026 18:53
stevehipwell
stevehipwell approved these changes Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell
Copy link
Copy Markdown
Collaborator

stevehipwell commented Mar 23, 2026

@robert-crandall please could you re-approve this PR?

deiga added 7 commits March 30, 2026 09:08
@deiga
Update resource ID to be <group-id>:<team-id>
e3eba55 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Fix tflog.SetField usage
34120b7 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Update tests to use terraform-plugin-testing and fix broken tests
f9ed0a8 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Update docs
c77988c 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Cleanup extra tflog.SetField calls
8a5819f 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Reducing logger complexity
3fa07bd 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Improve error messages in Import
85c5619 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga deiga force-pushed the consolidate-emu-group-mapping-id branch from f88c70f to 85c5619 Compare March 30, 2026 06:08
@stevehipwell stevehipwell merged commit 7bcb796 into integrations:main Apr 9, 2026
7 checks passed
@deiga deiga deleted the consolidate-emu-group-mapping-id branch April 9, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevehipwell stevehipwell stevehipwell approved these changes

@robert-crandall robert-crandall robert-crandall approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v6.12.0 Release

Development

Successfully merging this pull request may close these issues.

[MAINT] Consolidate ID in EMU group mapping resource

3 participants

@deiga @stevehipwell @robert-crandall