[MAINT] Consolidate ID format of github_emu_group_mapping#3215
Merged
stevehipwell merged 7 commits intointegrations:mainfrom Apr 9, 2026
Merged
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
stevehipwell
requested changes
Feb 23, 2026
Collaborator
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
This PR looks good, it's just the discussion about the log context to resolve.
deiga
force-pushed
the
consolidate-emu-group-mapping-id
branch
from
3480f37 to
472d4d6
Compare
stevehipwell
requested changes
Feb 24, 2026
Collaborator
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
I think we can remove a bit more complexity from the logging.
robert-crandall
previously approved these changes
Mar 13, 2026
Collaborator
|
@deiga could you please rebase this? |
deiga
dismissed stale reviews from robert-crandall and stevehipwell
via
f88c70f
deiga
force-pushed
the
consolidate-emu-group-mapping-id
branch
from
8977969 to
f88c70f
Compare
Collaborator
|
@robert-crandall please could you re-approve this PR? |
robert-crandall
approved these changes
Mar 23, 2026
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
deiga
force-pushed
the
consolidate-emu-group-mapping-id
branch
from
f88c70f to
85c5619
Compare
JiayangZhou
pushed a commit
to JiayangZhou/terraform-provider-github
that referenced
this pull request
Apr 16, 2026
…ions#3215) * Update resource ID to be <group-id>:<team-id> Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Fix `tflog.SetField` usage Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Update tests to use `terraform-plugin-testing` and fix broken tests Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Update docs Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Cleanup extra `tflog.SetField` calls Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Reducing logger complexity Signed-off-by: Timo Sand <timo.sand@f-secure.com> * Improve error messages in `Import` Signed-off-by: Timo Sand <timo.sand@f-secure.com> --------- Signed-off-by: Timo Sand <timo.sand@f-secure.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3200
Before the change?
tflog.SetFieldwas being used incorrectlyterraform-plugin-testingAfter the change?
tflog.SetFieldusageterraform-plugin-testingPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!