[MAINT] Improve Import behaviour of github_default_branch

ARCHITECTURE.md

@@ -95,7 +95,7 @@ func resourceExampleRead(ctx context.Context, d *schema.ResourceData, m any) dia
     // Single API call to get all needed data
     resource, _, err := client.Resources.Get(ctx, owner, name)
     if err != nil {
-        if ghErr, ok := errors.AsType[github.ErrorResponse](err); ok {
+        if ghErr, ok := errors.AsType[*github.ErrorResponse](err); ok {
             if ghErr.Response.StatusCode == http.StatusNotFound {
                 tflog.Info(ctx, "Removing resource from state because it no longer exists", map[string]any{"name": name})
                 d.SetId("")
@@ -342,7 +342,7 @@ Handle 404s gracefully by removing from state:
 ```go
 resource, _, err := client.Resources.Get(ctx, owner, name)
 if err != nil {
-    if ghErr, ok := errors.AsType[github.ErrorResponse](err); ok {
+    if ghErr, ok := errors.AsType[*github.ErrorResponse](err); ok {
         if ghErr.Response.StatusCode == http.StatusNotFound {
             tflog.Info(ctx, "Removing resource from state because it no longer exists", map[string]any{"name": name})
             d.SetId("")

docs/resources/branch_default.md

@@ -1,22 +1,20 @@
 ---
 page_title: "github_branch_default (Resource) - GitHub"
 description: |-
-  Provides a GitHub branch default for a given repository.
+  Configures the default branch for a GitHub repository.
 ---
 
 # github_branch_default (Resource)
 
-Provides a GitHub branch default resource.
+Configures the default branch for a GitHub repository.
 
-This resource allows you to set the default branch for a given repository.
-
-Note that use of this resource is incompatible with the `default_branch` option of the `github_repository` resource. Using both will result in plans always showing a diff.
+~> This resource is incompatible with the `default_branch` option of the [`github_repository`](repository) resource. Using both will result in plans always showing a diff.
 
 ## Example Usage
 
-Basic usage:
-
 ```terraform
+# Basic usage 
+
 resource "github_repository" "example" {
   name        = "example"
   description = "My awesome codebase"
@@ -34,9 +32,9 @@ resource "github_branch_default" "default" {
 }
 ```
 
-Renaming to a branch that doesn't exist:
-
 ```terraform
+# Renaming to a branch that doesn't exist
+
 resource "github_repository" "example" {
   name        = "example"
   description = "My awesome codebase"
@@ -50,17 +48,39 @@ resource "github_branch_default" "default" {
 }
 ```
 
-## Argument Reference
+<!-- schema generated by tfplugindocs -->
+## Schema
+
+### Required
+
+- `branch` (String) The name of the branch to set as the default (e.g. 'main').
+- `repository` (String) The name of the GitHub repository.
+
+### Optional
 
-The following arguments are supported:
+- `etag` (String) The ETag header for the repository API response.
+- `rename` (Boolean) If `true` rename the existing branch when the `branch` input is changed. Defaults to 'false'.
+- `wait_for_rename` (Boolean) If `true`, poll until GitHub propagates the renamed default branch before proceeding. Only has effect when `rename` is also `true`. Defaults to 'false'.
 
-- `repository` - (Required) The GitHub repository
-- `branch` - (Required) The branch (e.g. `main`)
-- `rename` - (Optional) Indicate if it should rename the branch rather than use an existing branch. Defaults to `false`.
+### Read-Only
+
+- `id` (String) The ID of this resource.
+- `repository_id` (Number) The ID of the GitHub repository.
 
 ## Import
 
-GitHub Branch Defaults can be imported using an ID made up of `repository`, e.g.
+Import is supported using the following syntax:
+
+In Terraform v1.5.0 and later, the [`import` block](https://developer.hashicorp.com/terraform/language/import) can be used with the `id` attribute, for example:
+
+```terraform
+import {
+  to = github_branch_default.default
+  id = "example"
+}
+```
+
+The [`terraform import` command](https://developer.hashicorp.com/terraform/cli/commands/import) can be used, for example:
 
 ```shell
 terraform import github_branch_default.branch_default my-repo

examples/resources/github_branch_default/import-by-string-id.tf

@@ -0,0 +1,4 @@
+import {
+  to = github_branch_default.default
+  id = "example"
+}

examples/resources/github_branch_default/import.sh

@@ -0,0 +1 @@
+terraform import github_branch_default.branch_default my-repo

examples/resources/branch_default/example_1.tf → examples/resources/github_branch_default/resource_basic.tf

@@ -1,3 +1,5 @@
+# Basic usage 
+
 resource "github_repository" "example" {
   name        = "example"
   description = "My awesome codebase"

examples/resources/branch_default/example_2.tf → examples/resources/github_branch_default/resource_rename_nonexistent_branch.tf

@@ -1,3 +1,5 @@
+# Renaming to a branch that doesn't exist
+
 resource "github_repository" "example" {
   name        = "example"
   description = "My awesome codebase"