Skip to content

feat: Refactor repository collaborators#3233

Merged
stevehipwell merged 1 commit intointegrations:mainfrom
stevehipwell:refactor-repo-collaborators
Mar 18, 2026
Merged

feat: Refactor repository collaborators#3233
stevehipwell merged 1 commit intointegrations:mainfrom
stevehipwell:refactor-repo-collaborators

Conversation

@stevehipwell
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell commented Feb 26, 2026

Resolves #2874

Before the change?

  • github_repository_collaborators errored if the repo was renamed
  • github_repository_collaborators prefered team ID and made extra calls if slug was used
  • github_repository_collaborators used unnecessary API calls to re-read
  • Team logic was inconsistent
  • Team resources didn't use native context

After the change?

  • github_repository_collaborators supports the repository being renamed
  • github_repository_collaborators uses the minimum number of API calls
  • Team logic is consistent and context is being used in more places

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@stevehipwell stevehipwell added this to the v6.12.0 Release milestone Feb 26, 2026
@stevehipwell stevehipwell self-assigned this Feb 26, 2026
@stevehipwell stevehipwell added Type: Bug Something isn't working as documented Type: Feature New feature or request labels Feb 26, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 26, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@stevehipwell stevehipwell mentioned this pull request Feb 26, 2026
Closed
1 task
@stevehipwell stevehipwell force-pushed the refactor-repo-collaborators branch 2 times, most recently from 55043eb to 4be7e25 Compare February 27, 2026 09:50
deiga
deiga reviewed Feb 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@deiga deiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review. Loving the direction here!

Comment thread github/resource_github_repository_collaborators.go
Comment thread github/resource_github_repository_collaborators.go
Comment thread github/util_team.go Outdated
@stevehipwell stevehipwell force-pushed the refactor-repo-collaborators branch from 4be7e25 to 42a9206 Compare February 27, 2026 13:43
@stevehipwell stevehipwell force-pushed the refactor-repo-collaborators branch from 42a9206 to 9e51b07 Compare March 16, 2026 22:56
@stevehipwell
Copy link
Copy Markdown
Collaborator Author

stevehipwell commented Mar 16, 2026

@robert-crandall please could you review this PR?

robert-crandall
robert-crandall previously approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown

@robert-crandall robert-crandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. I left some questions double checking intent.

Comment thread github/resource_github_repository_collaborators.go
Comment thread github/resource_github_repository_collaborators.go
Comment thread github/resource_github_repository_collaborators.go
@stevehipwell
feat: Refactor repository collaborators
cce7ad0 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell stevehipwell force-pushed the refactor-repo-collaborators branch from 9e51b07 to cce7ad0 Compare March 18, 2026 12:42
@stevehipwell
Copy link
Copy Markdown
Collaborator Author

stevehipwell commented Mar 18, 2026

@robert-crandall this should be good for a re-review.

@stevehipwell stevehipwell merged commit 11fc028 into integrations:main Mar 18, 2026
7 checks passed
@stevehipwell stevehipwell deleted the refactor-repo-collaborators branch March 18, 2026 18:05
@deiga deiga mentioned this pull request Mar 22, 2026
Closed
1 task
JiayangZhou pushed a commit to JiayangZhou/terraform-provider-github that referenced this pull request Apr 16, 2026
@stevehipwell @JiayangZhou
feat: Refactor repository collaborators (integrations#3233)
4c75965 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deiga deiga deiga left review comments

@robert-crandall robert-crandall robert-crandall approved these changes

@nickfloyd nickfloyd Awaiting requested review from nickfloyd

Assignees

@stevehipwell stevehipwell

Labels

Type: Bug Something isn't working as documented Type: Feature New feature or request

Projects

None yet

Milestone

v6.12.0

Development

Successfully merging this pull request may close these issues.

[BUG]: github_repository_collaborators error on repository rename

3 participants

@stevehipwell @deiga @robert-crandall