Skip to content

GitHub organization repositories#3243

Open
borchero wants to merge 12 commits intointegrations:mainfrom
borchero:github-organization-repositories
Open

GitHub organization repositories#3243
borchero wants to merge 12 commits intointegrations:mainfrom
borchero:github-organization-repositories

Conversation

@borchero
Copy link
Copy Markdown

@borchero borchero commented Feb 28, 2026 •
edited
Loading

Resolves #2484, supersedes #2485 which I cannot reopen

Before the change?

see issue

After the change?

  • There exists a new github_organization_repositories data source providing details about all repositories in an organization
    • The set of details returned is kept small for now (both to gauge an understanding of whether this can make it into the provider and to not unnecessarily blow up the API from the get-go)

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 28, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

deiga
deiga requested changes Mar 1, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@deiga deiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does exist in data_source_github_organization already, but I think that should maybe be deprecated. Could you mark this as deprecated?

@borchero
Copy link
Copy Markdown
Author

borchero commented Mar 1, 2026

Done, thanks for the quick review @deiga!

@borchero borchero requested a review from deiga March 1, 2026 13:57
deiga
deiga requested changes Mar 1, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@deiga deiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more comments :)

@borchero borchero requested a review from deiga March 1, 2026 15:39
deiga
deiga requested changes Mar 1, 2026
View reviewed changes
@borchero borchero requested a review from deiga March 1, 2026 22:01
deiga
deiga requested changes Mar 1, 2026
View reviewed changes
borchero and others added 2 commits March 1, 2026 23:12
deiga
deiga previously approved these changes Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@deiga deiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @stevehipwell WDYT?

@deiga deiga requested a review from stevehipwell March 2, 2026 21:45
stevehipwell
stevehipwell requested changes Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @borchero. I've added a few review comments.

github/data_source_github_organization_repositories.go Outdated
Computed: true,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"repo_id": {
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"repo_id": {
"repository_id": {

This would be more consistent, although given that we're using name below maybe this should be id? WDYT @deiga?

Copy link
Copy Markdown
Collaborator

@deiga deiga Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we use repo_id somewhere else as well.
But I agree that either we use repository_id or just id. The latter is harder to grep but cleaner to use 🤔

I think I'm leaning towards just id

Copy link
Copy Markdown
Author

@borchero borchero Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went for id ✅

@borchero borchero requested a review from stevehipwell March 3, 2026 10:19
@borchero
Copy link
Copy Markdown
Author

borchero commented Mar 18, 2026

@stevehipwell friendly ping :)

@deiga
Copy link
Copy Markdown
Collaborator

deiga commented Mar 18, 2026

@borchero Nothing friendly about pinging on an unrebased PR

@borchero
Copy link
Copy Markdown
Author

borchero commented Mar 19, 2026

Sorry @deiga, I felt like this was in a fine state since there was no conflict with main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deiga deiga deiga left review comments

@stevehipwell stevehipwell Awaiting requested review from stevehipwell

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEAT]: github_organization_repositories data source

3 participants

@borchero @deiga @stevehipwell