Skip to content

[MAINT] Modernize github_repository resource #3310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deiga wants to merge 15 commits into
base: main
Choose a base branch
from
Open

[MAINT] Modernize github_repository resource #3310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ddda76f
Refactor tests to use testing plugin
deiga Mar 27, 2026
95f6856
Refactor to use `tflog`
deiga Mar 28, 2026
24a7373
Remove gate for `archived` repos in Read.
deiga Mar 28, 2026
c9fbaa9
Refactor to no longer call CRUD methods directly
deiga Mar 28, 2026
7c3c2b0
Enable parallel testing
deiga Mar 28, 2026
f756b56
Reduce to using a single `d.SetId` in `Create`
deiga Mar 28, 2026
ff0ea27
Remove unnecessary copy-pasta
deiga Mar 28, 2026
0217f3e
Minor cleanup
deiga Mar 28, 2026
17455f9
Add missing field to repo DS
deiga Mar 29, 2026
edbc06a
Update docs
deiga Mar 29, 2026
c59191a
Add validation for merge and squash merge configs
deiga Mar 29, 2026
bb1290a
Refactor to use only `CustomizeDiff` for validation
deiga Mar 29, 2026
c820025
Improve structure of `setResourceFieldsFromRepo`
deiga Mar 29, 2026
503e6d1
Cleaning some tests
deiga Mar 30, 2026
0b52c2c
Enable primary_language test
deiga Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion GNUmakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ test:
testacc:
@branch=$$(git rev-parse --abbrev-ref HEAD); \
printf "==> Running acceptance tests on branch: \033[1m%s\033[0m...\n" "🌿 $$branch 🌿"
TF_ACC=1 CGO_ENABLED=0 go test $(TEST) -v -run '^TestAcc' $(RUNARGS) $(TESTARGS) -timeout 120m -count=1
TF_ACC=1 CGO_ENABLED=0 go test $(TEST) -parallel=4 -v -run '^TestAcc' $(RUNARGS) $(TESTARGS) -timeout 120m -count=1

sweep:
@echo "WARNING: This will destroy infrastructure. Use only in development accounts."
Expand Down
6 changes: 6 additions & 0 deletions github/data_source_github_repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,11 @@ func dataSourceGithubRepository() *schema.Resource {
Type: schema.TypeBool,
Computed: true,
},
"web_commit_signoff_required": {
Type: schema.TypeBool,
Computed: true,
Description: "Require contributors to sign off on web-based commits.",
},
},
}
}
Expand Down Expand Up @@ -414,6 +419,7 @@ func dataSourceGithubRepositoryRead(ctx context.Context, d *schema.ResourceData,
_ = d.Set("has_projects", repo.GetHasProjects())
_ = d.Set("delete_branch_on_merge", repo.GetDeleteBranchOnMerge())
_ = d.Set("allow_update_branch", repo.GetAllowUpdateBranch())
_ = d.Set("web_commit_signoff_required", repo.GetWebCommitSignoffRequired())

if repo.GetHasPages() {
pages, _, err := client.Repositories.GetPagesInfo(ctx, owner, repoName)
Expand Down
Loading