migrate github_user_gpg_key to context-aware CRUD functions#3330
Closed
texasich wants to merge 1 commit intointegrations:mainfrom
Closed
migrate github_user_gpg_key to context-aware CRUD functions#3330texasich wants to merge 1 commit intointegrations:mainfrom
texasich wants to merge 1 commit intointegrations:mainfrom
Conversation
Switch Create/Read/Delete to CreateContext/ReadContext/DeleteContext and update function signatures to accept ctx and return diag.Diagnostics. Removes inline context.Background() and context.WithValue() calls that are now redundant since ctx flows in from the SDK. Part of integrations#2996.
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
github-actions
bot
added
the
Type: Maintenance
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2996
Migrates
resource_github_user_gpg_keyfrom the deprecated non-context-aware SDK signatures toCreateContext/ReadContext/DeleteContext, updating return types fromerrortodiag.Diagnosticsthroughout.Changes:
Create/Read/Delete?CreateContext/ReadContext/DeleteContextin the resource structctx context.Contextand returndiag.Diagnosticscontext.Background()andcontext.WithValue()calls (ctx now flows in from the SDK)return err?return diag.FromErr(err)Built and
go vet ./...clean.