maint: migrate data sources to tflog structured logging#3346
Open
feyzsari wants to merge 1 commit intointegrations:mainfrom
Open
maint: migrate data sources to tflog structured logging#3346feyzsari wants to merge 1 commit intointegrations:mainfrom
feyzsari wants to merge 1 commit intointegrations:mainfrom
Conversation
Replace standard log.Printf calls with tflog.Debug using structured fields in the following data sources: - data_source_github_actions_organization_registration_token - data_source_github_actions_registration_token - data_source_github_branch Part of integrations#2629
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
github-actions
Bot
added
the
Type: Maintenance
Collaborator
|
Please remove the resolves comment, since it adresses the issue only partly. And "resolves" will close the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2629
Before the change?
data_source_github_actions_organization_registration_token,data_source_github_actions_registration_token,and
data_source_github_branchused the standardlogpackage withlog.Printf("[DEBUG] ..."),embedding values directly in the message string.
After the change?
Replaced
logimports withgithub.com/hashicorp/terraform-plugin-log/tflog.Log calls now use
tflog.Debug(ctx, "...", map[string]any{...})with structured fields,providing proper integration with Terraform's logging system (TF_LOG, TF_LOG_PROVIDER)
and enabling field-based log filtering.
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!