[MAINT] Upgrade go-jose to v4#3357
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
4b91775 to
f9da97e
Compare
|
@deiga could you rebase this? I assume you've run the tests locally? We ought to update the PR checklist to capture if tests have been run locally with a box to put the output in. |
|
@stevehipwell Would that fit into this PR? #3261 Yeah, I'll rebase. And I had run all test that use |
|
@deiga it looks like @robert-crandall isn't currently online (based on Slack). I think we're OK to merge the Dependabot updates with an approval from both of us, so shall we do those and then you can rebase this PR afterwards? |
|
@deiga could you please rebase this PR? |
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
|
@stevehipwell Done |
|
@robert-crandall could you please approve this (or let us know that for changes like this you're happy for us to have a single maintainer approval)? |
Resolves #3350
Before the change?
go-joseAfter the change?
go-joseand can prepare for upcoming release of v5Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!