Skip to content

[MAINT] Upgrade go-jose to v4#3357

Merged
deiga merged 1 commit intointegrations:mainfrom
F-Secure-web:upgrade-go-jose-v4
May 7, 2026
Merged

[MAINT] Upgrade go-jose to v4#3357
deiga merged 1 commit intointegrations:mainfrom
F-Secure-web:upgrade-go-jose-v4

Conversation

@deiga
Copy link
Copy Markdown
Collaborator

@deiga deiga commented Apr 21, 2026

Resolves #3350


Before the change?

  • We we're using deprecated v3 of go-jose

After the change?

  • We are now using v4 of go-jose and can prepare for upcoming release of v5

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@deiga deiga added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Apr 21, 2026
@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@deiga deiga added this to the v6.13.0 milestone Apr 21, 2026
@deiga deiga requested a review from stevehipwell April 24, 2026 07:17
@deiga deiga force-pushed the upgrade-go-jose-v4 branch from 4b91775 to f9da97e Compare April 24, 2026 07:19
@stevehipwell
Copy link
Copy Markdown
Collaborator

@deiga could you rebase this? I assume you've run the tests locally?

We ought to update the PR checklist to capture if tests have been run locally with a box to put the output in.

@deiga
Copy link
Copy Markdown
Collaborator Author

deiga commented May 6, 2026

@stevehipwell Would that fit into this PR? #3261

Yeah, I'll rebase. And I had run all test that use go-jose features

@deiga deiga force-pushed the upgrade-go-jose-v4 branch from f9da97e to 83b6b23 Compare May 6, 2026 12:42
stevehipwell
stevehipwell previously approved these changes May 6, 2026
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deiga deiga requested a review from robert-crandall May 6, 2026 12:46
@deiga deiga force-pushed the upgrade-go-jose-v4 branch from 83b6b23 to 318493e Compare May 6, 2026 12:46
@stevehipwell
Copy link
Copy Markdown
Collaborator

@deiga it looks like @robert-crandall isn't currently online (based on Slack). I think we're OK to merge the Dependabot updates with an approval from both of us, so shall we do those and then you can rebase this PR afterwards?

@stevehipwell
Copy link
Copy Markdown
Collaborator

@deiga could you please rebase this PR?

Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Copy link
Copy Markdown
Collaborator Author

deiga commented May 7, 2026

@stevehipwell Done

Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell
Copy link
Copy Markdown
Collaborator

@robert-crandall could you please approve this (or let us know that for changes like this you're happy for us to have a single maintainer approval)?

@deiga deiga merged commit d471499 into integrations:main May 7, 2026
9 checks passed
@deiga deiga deleted the upgrade-go-jose-v4 branch May 7, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MAINT]: Upgrade go-jose to v4

3 participants