doc(data github_app): Add id on data source GitHub app documentation

[ViacheslavKudinov]

Resolves #2819

---

Before the change?

• The attribute id is not present in documentation but is actually there
• "Static" doc

After the change?

• The attribute id is on github_app data source documentation
• Doc generated based on schema and example by tfdoc

Pull request checklist

• Schema migrations have been created if needed (example)
• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes
• No

---

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[stevehipwell]

@ViacheslavKudinov you could automate this document either by merging templates/data-sources.md.tmpl with this specific template, or deleting this template and using the default. In both cases you just need to make sure the schema comments are correct so as to not lose any information.

[ViacheslavKudinov]

@stevehipwell updated PR.
Please, take a look if anything else needs to be changed.
Thank you in advance.

PS what is expected to be in "subcategory" ?

[stevehipwell]

PS what is expected to be in "subcategory" ?

It's expected to be empty.

[stevehipwell]

LGTM

[stevehipwell]

@robert-crandall this is one of the kinds of PRs that I don't think there is much value requiring a staff approval. What do you think?

[deiga]

Could you verify if my hunch is correct?

[stevehipwell]

@deiga it could be removed, it's in my comment from earlier. I'm kind of on the fence about which is better. Technically having a specific template is quicker and makes it easier to improve the documentation. But having a template does potentially require maintenance in the future.

[deiga]

@deiga it could be removed, it's in my comment from earlier. I'm kind of on the fence about which is better. Technically having a specific template is quicker and makes it easier to improve the documentation. But having a template does potentially require maintenance in the future.

Copying the template when needed sounds super quick and reduces overhead of keeping up with generic template changes

[deiga]

LGTM