[FEAT]: Enable Use bypass_actor for Organization Rulesets#3468
Open
deiga wants to merge 4 commits into
Open
Conversation
|
👋 Hi, and thank you for this contribution! This repo is maintained by GitHub and community members on a best-effort basis. We'll get to this as soon as we can. You can help us prioritize by joining the discussion on open issues and PRs, sharing details on the changes you need, and reviewing other contributions. 🤖 This is an automated message. |
b527aee to
ccad8e4
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
These provider review instructions are being used. This PR enables User as a valid bypass_actors.actor_type for the github_organization_ruleset resource and switches the organization ruleset docs to be primarily schema-generated.
Changes:
- Allow
bypass_actors.actor_type = "User"ingithub_organization_ruleset(schema validation + docs text). - Add an acceptance test that creates an org ruleset with a
Userbypass actor. - Simplify
organization_rulesetdocs templating to rely onSchemaMarkdownoutput (and refresh generated docs accordingly).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
github/resource_github_organization_ruleset.go |
Adds resource-level description, updates bypass actor schema to accept User, and adjusts schema descriptions used for generated docs. |
github/resource_github_organization_ruleset_test.go |
Adds an acceptance test covering creation of an org ruleset with a User bypass actor. |
templates/resources/organization_ruleset.md.tmpl |
Replaces the hand-written argument docs with schema-generated markdown (SchemaMarkdown) and uses the resource description as the page summary. |
docs/resources/organization_ruleset.md |
Updates the rendered documentation to match the new schema-generated template output. |
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
ebf98b7 to
edda4b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially resolves #3423
Before the change?
Userasbypass_actorin Organization RulesetsAfter the change?
Userasbypass_actorin Organization RulesetsPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!