Skip to content

[FEAT]: Enable Use bypass_actor for Organization Rulesets#3468

Open
deiga wants to merge 4 commits into
integrations:mainfrom
F-Secure-web:add-user-bypass-actor-org-ruleset
Open

[FEAT]: Enable Use bypass_actor for Organization Rulesets#3468
deiga wants to merge 4 commits into
integrations:mainfrom
F-Secure-web:add-user-bypass-actor-org-ruleset

Conversation

@deiga
Copy link
Copy Markdown
Collaborator

@deiga deiga commented Jun 2, 2026

Partially resolves #3423


Before the change?

  • It was not possible to configure a User as bypass_actor in Organization Rulesets

After the change?

  • Now it is possible to configure a User as bypass_actor in Organization Rulesets
  • The docs contents are generated almost entirely from Org Ruleset resource schema

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

👋 Hi, and thank you for this contribution!

This repo is maintained by GitHub and community members on a best-effort basis. We'll get to this as soon as we can.

You can help us prioritize by joining the discussion on open issues and PRs, sharing details on the changes you need, and reviewing other contributions.


🤖 This is an automated message.

@deiga deiga force-pushed the add-user-bypass-actor-org-ruleset branch from b527aee to ccad8e4 Compare June 2, 2026 18:10
@deiga deiga marked this pull request as ready for review June 2, 2026 18:10
@deiga deiga requested a review from Copilot June 2, 2026 18:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

These provider review instructions are being used. This PR enables User as a valid bypass_actors.actor_type for the github_organization_ruleset resource and switches the organization ruleset docs to be primarily schema-generated.

Changes:

  • Allow bypass_actors.actor_type = "User" in github_organization_ruleset (schema validation + docs text).
  • Add an acceptance test that creates an org ruleset with a User bypass actor.
  • Simplify organization_ruleset docs templating to rely on SchemaMarkdown output (and refresh generated docs accordingly).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
github/resource_github_organization_ruleset.go Adds resource-level description, updates bypass actor schema to accept User, and adjusts schema descriptions used for generated docs.
github/resource_github_organization_ruleset_test.go Adds an acceptance test covering creation of an org ruleset with a User bypass actor.
templates/resources/organization_ruleset.md.tmpl Replaces the hand-written argument docs with schema-generated markdown (SchemaMarkdown) and uses the resource description as the page summary.
docs/resources/organization_ruleset.md Updates the rendered documentation to match the new schema-generated template output.

Comment thread github/resource_github_organization_ruleset.go
@deiga deiga added this to the v6.13.0 milestone Jun 2, 2026
@deiga deiga requested a review from stevehipwell June 2, 2026 20:14
deiga added 4 commits June 3, 2026 21:26
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga deiga force-pushed the add-user-bypass-actor-org-ruleset branch from ebf98b7 to edda4b1 Compare June 3, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: Support User actor type in bypass_actors for ruleset

2 participants