Minor fixes and refactors.

Author: igorban-intel

IGC/VectorCompiler/lib/GenXCodeGen/GenXConstants.cpp

@@ -2043,22 +2043,19 @@ void ConstantLoader::analyzeForPackedInt(unsigned NumElements) {
       // packed unsigned int with no extra scaling or adjustment.
       PackedIntScale = 1;
       PackedIntAdjust = 0;
-      PackedIntMax = Max;
       return;
     }
     if (Min >= ImmIntVec::MinSInt && Max <= ImmIntVec::MaxSInt) {
       // Values all in the range [MinSInt..MaxSInt]. We can do this with a
       // packed unsigned int with no extra scaling or adjustment.
       PackedIntScale = 1;
       PackedIntAdjust = -8;
-      PackedIntMax = Max + 8;
       return;
     }
     // Values all in the range [Min..Min+MaxUInt]. We can do this
     // with a packed int with an adjustment.
     PackedIntScale = 1;
     PackedIntAdjust = Min;
-    PackedIntMax = Max - Min;
     return;
   }
   // Get unique absolute differences, so we can detect if we have a valid
@@ -2097,7 +2094,6 @@ void ConstantLoader::analyzeForPackedInt(unsigned NumElements) {
       return; // range of values too big
   }
   PackedIntScale = CurScale;
-  PackedIntMax = ImmIntVec::MaxUInt;
   // Special case adjust of 0 or -8 as then we can save doing an adjust at all
   // by using unsigned or signed packed vector respectively.
   if (!(Min % CurScale)) {
@@ -2115,7 +2111,6 @@ void ConstantLoader::analyzeForPackedInt(unsigned NumElements) {
              CurScale, static_cast<int64_t>(ImmIntVec::MaxSInt), ResArith) &&
          Max <= ResArith)) {
       PackedIntAdjust = Min;
-      PackedIntMax = ImmIntVec::MaxSInt;
       return;
     }
     // Special case all pre-scaled values being in [-15,0] as we can do that

IGC/VectorCompiler/lib/GenXCodeGen/GenXConstants.h

@@ -46,9 +46,6 @@ class ConstantLoader {
   int64_t PackedIntScale = 0;  // amount to scale packed int vector by
   int64_t PackedIntAdjust = 0; // amount to adjust by, special casing 0 or -8
                                //  when PackedIntScale is 1
-  unsigned PackedIntMax = 0;   // max value in packed vector, used when scale is
-                             //  1 and adjust is 0 to tell whether it would fit
-                             //  in 0..7
   bool PackedFloat = false;
 
 public: