Merge pull request #115 from intel/intel_lpmd_next

Intel lpmd next

Author: spandruvada

README.md

@@ -1,8 +1,19 @@
 # Intel Low Power Mode Daemon
 
-Intel Low Power Mode Daemon (lpmd) is a Linux daemon designed to optimize active idle power. It selects the most power-efficient CPUs based on a configuration file or CPU topology. Depending on system utilization and other hints, it puts the system into Low Power Mode by activating the power-efficient CPUs and disabling the rest, and restores the system from Low Power Mode by activating all CPUs.
+Intel Low Power Mode Daemon (lpmd) is a Linux daemon designed to optimize active
+idle power. It selects the most power-efficient CPUs based on a configuration
+file or CPU topology. Depending on system utilization and other hints, it puts
+the system into Low Power Mode by activating the power-efficient CPUs and
+disabling the rest, and restores the system from Low Power Mode by activating
+all CPUs.
 
-## Usage
+## Before You Start
+
+**Please note** that the installed configuration files serve as templates of
+best practices for specific platform models and disable lpmd by default. For
+LPMD to start the user is expected to either edit the main
+"intel_lpmd_config.xml" config file or after starting the program, enable LPMD
+by using the intel_lpmd_control tool.
 
 Refer to the man pages for command line arguments and XML configurations:
 
@@ -40,10 +51,13 @@ make
 sudo make install
 ```
 
-The generated artifacts are copied to respective directories under `/usr/local`. If a custom install path is preferred other than system default,  make sure `--localstatedir` and `--sysconfdir` are set to the right path that the system can understand. If installed via RPM then artifacts would be under `/usr`.
-
-Example command for installation using prefix under `/opt/lpmd_install` dir with `--localstatedir` and `--sysconfdir` set to system default
+The generated artifacts are copied to respective directories under `/usr/local`.
+If a custom install path is preferred other than system default,  make sure
+`--localstatedir` and `--sysconfdir` are set to the right path that the system
+can understand. If installed via RPM then artifacts would be under `/usr`.
 
+Example command for installation using prefix under `/opt/lpmd_install` dir with
+`--localstatedir` and `--sysconfdir` set to system default
 
 ```sh
 ./autogen.sh prefix=/opt/lpmd_install --localstatedir=/var --sysconfdir=/etc
@@ -87,8 +101,8 @@ Start `lpmd` using:
 sudo sh tests/lpm_test_interface.sh 4
 ```
 
-Run a workload and monitor `lpmd` to ensure it puts the system in the appropriate state based on the load.
-
+Run a workload and monitor `lpmd` to ensure it puts the system in the
+appropriate state based on the load.
 
 ## Releases
 

configure.ac

@@ -1,4 +1,4 @@
-AC_PREREQ(1.0)
+AC_PREREQ([1.0])
 
 m4_define([lpmd_major_version], [0])
 m4_define([lpmd_minor_version], [1.0])
@@ -9,36 +9,36 @@ AC_INIT([intel_lpmd], [lpmd_version], [], [intel_lpmd])
 m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES([yes])])
 
 AC_CONFIG_MACRO_DIR([m4])
-AC_CONFIG_AUX_DIR(build-aux)
+AC_CONFIG_AUX_DIR([build-aux])
 AC_CONFIG_HEADERS([config.h])
 
 AM_INIT_AUTOMAKE([1.11 foreign no-define subdir-objects])
 AM_MAINTAINER_MODE([enable])
 
 GTK_DOC_CHECK([1.11],[--flavour no-tmpl])
 
-AC_ARG_WITH(dbus-sys-dir, AS_HELP_STRING([--with-dbus-sys-dir=DIR], [where D-BUS system.d directory is]))
-if test -n "$with_dbus_sys_dir" ; then
+AC_ARG_WITH([dbus-sys-dir], [AS_HELP_STRING([--with-dbus-sys-dir=DIR], [where D-BUS system.d directory is])])
+AS_IF([test -n "$with_dbus_sys_dir"], [
     DBUS_SYS_DIR="$with_dbus_sys_dir"
-else
+], [
     DBUS_SYS_DIR="/etc/dbus-1/system.d"
-fi
-AC_SUBST(DBUS_SYS_DIR)
+])
+AC_SUBST([DBUS_SYS_DIR])
 
 # paths
-AC_SUBST(lpmd_binary, "$sbindir/$PACKAGE", [Binary executable])
-AC_SUBST(lpmd_confdir, "$sysconfdir/$PACKAGE", [Configuration directory])
-AC_SUBST(lpmd_rundir, "$localstatedir/run/$PACKAGE", [Runtime state directory])
+AC_SUBST([lpmd_binary], ["$sbindir/$PACKAGE"], [Binary executable])
+AC_SUBST([lpmd_confdir], ["$sysconfdir/$PACKAGE"], [Configuration directory])
+AC_SUBST([lpmd_rundir], ["$localstatedir/run/$PACKAGE"], [Runtime state directory])
 
 PKG_PROG_PKG_CONFIG
 AC_ARG_WITH([systemdsystemunitdir],
-        AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd service files]),
-        [], [with_systemdsystemunitdir=$($PKG_CONFIG --variable=systemdsystemunitdir systemd)])
-if test "x$with_systemdsystemunitdir" != xno; then
+	[AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd service files])],
+	[], [with_systemdsystemunitdir=$($PKG_CONFIG --variable=systemdsystemunitdir systemd)])
+AS_IF([test "x$with_systemdsystemunitdir" != xno], [
         AC_SUBST([systemdsystemunitdir], [$with_systemdsystemunitdir])
-fi
+])
 
-AM_CONDITIONAL(HAVE_SYSTEMD, [test -n "$with_systemdsystemunitdir" -a "x$with_systemdsystemunitdir" != xno ])
+AM_CONDITIONAL([HAVE_SYSTEMD], [test -n "$with_systemdsystemunitdir" && test "x$with_systemdsystemunitdir" != xno])
 
 # print configuration
 echo
@@ -52,26 +52,26 @@ echo "  lpmd_rundir: $lpmd_rundir"
 echo
 
 GETTEXT_PACKAGE=intel_lpmd
-AC_SUBST(GETTEXT_PACKAGE)
-AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE,"$GETTEXT_PACKAGE", [Gettext package])
+AC_SUBST([GETTEXT_PACKAGE])
+AC_DEFINE_UNQUOTED([GETTEXT_PACKAGE], ["$GETTEXT_PACKAGE"], [Gettext package])
 
 GLIB_VERSION_DEFINES="-DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26"
 
-PKG_CHECK_MODULES(GLIB, gio-unix-2.0 >= 2.22 gmodule-2.0 glib-2.0 gobject-2.0)
+PKG_CHECK_MODULES([GLIB], [gio-unix-2.0 >= 2.22 gmodule-2.0 glib-2.0 gobject-2.0])
 GLIB_CFLAGS="$GLIB_CFLAGS $GLIB_VERSION_DEFINES"
-AC_SUBST(GLIB_CFLAGS)
-AC_SUBST(GLIB_LIBS)
+AC_SUBST([GLIB_CFLAGS])
+AC_SUBST([GLIB_LIBS])
 
-PKG_CHECK_MODULES(XML, libxml-2.0 >= 2.4)
+PKG_CHECK_MODULES([XML], [libxml-2.0 >= 2.4])
 
-PKG_CHECK_MODULES(libnl30, [libnl-3.0], libnl30=yes, libnl30=no)
-PKG_CHECK_MODULES(libnlgenl30, [libnl-genl-3.0], libnlgenl30=yes, libnlgenl30=no)
+PKG_CHECK_MODULES([libnl30], [libnl-3.0], [libnl30=yes], [libnl30=no])
+PKG_CHECK_MODULES([libnlgenl30], [libnl-genl-3.0], libnlgenl30=yes, libnlgenl30=no)
 
 PKG_CHECK_MODULES([SYSTEMD], [libsystemd], [],
       [PKG_CHECK_MODULES([SYSTEMD], [libsystemd-daemon], [],
-       AC_MSG_ERROR([libsystemd support requested but found]))])
+       [AC_MSG_ERROR([libsystemd support requested but not found])])])
 
-PKG_CHECK_MODULES(UPOWER, upower-glib)
+PKG_CHECK_MODULES([UPOWER], [upower-glib])
 
 AC_PATH_PROG([GDBUS_CODEGEN],[gdbus-codegen])
 
@@ -81,14 +81,14 @@ AC_C_CONST
 AC_C_INLINE
 AC_TYPE_SIZE_T
 
-AC_ARG_ENABLE(werror, AS_HELP_STRING([--disable-werror], [Disable -Werror]))
+AC_ARG_ENABLE([werror], [AS_HELP_STRING([--disable-werror], [Disable -Werror])])
 AS_IF([test "x$enable_werror" != "xno"], [CFLAGS="$CFLAGS -Werror"])
 
 AC_CONFIG_FILES([Makefile
                  data/Makefile
                  tools/Makefile])
 
-AC_ARG_ENABLE(gdbus,
+AC_ARG_ENABLE([gdbus],
               [AS_HELP_STRING([--disable-gdbus],
                               [Switch DBus backend to glib-dbus. (Default: GDBus)])],
               [],

data/intel_lpmd_config_F6_M204.xml

@@ -146,19 +146,19 @@ for Intel Energy Optimizer (LPMD) daemon
 			<ID> 1 </ID>
 			<Name> UTIL_IDLE </Name>
 			<WLTType> 1 </WLTType>
-			<ActiveCPUs>16-19</ActiveCPUs>
+			<ActiveCPUs>12-15</ActiveCPUs>
 		</State>
 		<State>
 			<ID> 2 </ID>
 			<Name> UTIL_IDLE_SUSTAIN </Name>
 			<WLTType> 2 </WLTType>
-			<ActiveCPUs>0-19</ActiveCPUs>
+			<ActiveCPUs>0-15</ActiveCPUs>
 		</State>
 		<State>
 			<ID> 3 </ID>
 			<Name> UTIL_IDLE_BURSTY </Name>
 			<WLTType> 3 </WLTType>
-			<ActiveCPUs>0-19</ActiveCPUs>
+			<ActiveCPUs>0-15</ActiveCPUs>
 		</State>
 	</States>
 
@@ -186,4 +186,28 @@ for Intel Energy Optimizer (LPMD) daemon
 		</State>
 	</States>
 
+	<States>
+		<CPUFamily> 6 </CPUFamily>
+		<CPUModel> 204 </CPUModel>
+		<CPUConfig> 4P0E4L-25W </CPUConfig>
+		<State>
+			<ID> 1 </ID>
+			<Name> UTIL_IDLE </Name>
+			<WLTType> 1 </WLTType>
+			<ActiveCPUs>4-7</ActiveCPUs>
+		</State>
+		<State>
+			<ID> 2 </ID>
+			<Name> UTIL_IDLE_SUSTAIN </Name>
+			<WLTType> 2 </WLTType>
+			<ActiveCPUs>0-7</ActiveCPUs>
+		</State>
+		<State>
+			<ID> 3 </ID>
+			<Name> UTIL_IDLE_BURSTY </Name>
+			<WLTType> 3 </WLTType>
+			<ActiveCPUs>0-7</ActiveCPUs>
+		</State>
+	</States>
+
 </Configuration>

data/org.freedesktop.intel_lpmd.conf

@@ -16,9 +16,5 @@
                 <deny send_destination="org.freedesktop.intel_lpmd"/>
                 <allow receive_sender="org.freedesktop.intel_lpmd"/>
         </policy>
-        <policy group="power">
-                <allow send_destination="org.freedesktop.intel_lpmd"/>
-                <allow receive_sender="org.freedesktop.intel_lpmd"/>
-        </policy>
 
 </busconfig>

man/intel_lpmd.8

@@ -21,7 +21,7 @@
 .\"
 .\" Copyright (C) 2012 Intel Corporation. All rights reserved.
 .\"
-.TH intel_lpmd "8" "1 Jun 2023"
+.TH intel_lpmd "8" "08 Apr 2026"
 
 .SH NAME
 intel_lpmd \- Intel Energy Optimizer (LPMD) Daemon
@@ -31,25 +31,24 @@ intel_lpmd \- Intel Energy Optimizer (LPMD) Daemon
 
 .SH DESCRIPTION
 .B intel_lpmd
-is a Linux daemon used for energy optimization on Intel hybrid systems.
-This daemon uses a configuration file "intel_lpmd_config.xml".
-Based on the configuration, it will choose right set of CPUs
-to enable. For example, this daemon can monitor system utilization
-and choose a set of low power CPUs to enable and disable the rest.
-This enable disable of CPUs are done using Linux cpuset feature
-of intel power clamp driver.
-
-There is a control utility distributed along with this daemon.
-This control utility is called "intel_lpmd_control". This utility
-can be used to set different modes for this daemon.
-For example:
-intel_lpmd_control ON
-	To turn on low power mode operation.
-intel_lpmd_control OFF
-	To turn off low power mode operation.
-intel_lpmd_control AUTO
-	To turn on low power mode operation in auto mode, which
-	allows low power mode based on system utilization.
+is a Linux daemon used for energy optimization on Intel hybrid systems. This
+daemon uses a configuration file called "intel_lpmd_config.xml". The other
+installed configuration files are to be treated as best practice templates. The
+main configuration file should be edited by the user to enable LPMD and it's
+desired functionalities. Based on the configuration and system utilization LPMD
+can:
+
+- choose the best set of CPU cores to enable for a given moment in time
+
+- choose the best EPP (energe performance preference) and EPB (energy
+performance bias) value
+
+- pick the best SoC power slider settings
+
+There is a control utility distributed along with this daemon. It's called
+"intel_lpmd_control" and it can be used to change modes in the running LPMD
+instance.
+
 .SH OPTIONS
 .TP
 .B -h --help
@@ -88,8 +87,13 @@ Run intel_lpmd with log directed to stdout
 .B intel_lpmd --systemd --dbus-enable
 Run intel_lpmd as a service with logs directed to system journal
 
+.TP
+.B sudo systemctl enable intel_lpmd.service --now
+Enable and run intel_lpmd as a systemd service that's persistent after system
+reboot.
+
 .SH SEE ALSO
-intel_lpmd_config.xml(5)
+intel_lpmd_config.xml(5), intel_lpmd_control(8)
 
 .SH AUTHOR
 Written by Zhang Rui <rui.zhang@intel.com>