Skip to content

Commit 3404ad4

Browse files
lwfingergregkh
authored andcommitted
staging: rtl8188eu: Fix potential overuse of kernel memory
commit 4ddf8ab upstream. In routine wpa_supplicant_ioctl(), the user-controlled p->length is checked to be at least the size of struct ieee_param size, but the code does not detect the case where p->length is greater than the size of the struct, thus a malicious user could be wasting kernel memory. Fixes commit a2c60d4 ("Add files for new driver - part 16"). Reported by: Pietro Oliva <pietroliva@gmail.com> Cc: Pietro Oliva <pietroliva@gmail.com> Cc: Stable <stable@vger.kernel.org> Fixes commit a2c60d4 ("Add files for new driver - part 16"). Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Link: https://lore.kernel.org/r/20200210180235.21691-4-Larry.Finger@lwfinger.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent d6cb533 commit 3404ad4

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/staging/rtl8188eu/os_dep/ioctl_linux.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2052,7 +2052,7 @@ static int wpa_supplicant_ioctl(struct net_device *dev, struct iw_point *p)
20522052
struct ieee_param *param;
20532053
uint ret = 0;
20542054

2055-
if (p->length < sizeof(struct ieee_param) || !p->pointer) {
2055+
if (!p->pointer || p->length != sizeof(struct ieee_param)) {
20562056
ret = -EINVAL;
20572057
goto out;
20582058
}

0 commit comments

Comments
 (0)