Skip to content

Commit c52df6a

Browse files
committed
scsi: ses: Handle positive SCSI error from ses_recv_diag()
commit 7a9f448d44127217fabc4065c5ba070d4e0b5d37 upstream. ses_recv_diag() can return a positive value, which also means that an error happened, so do not only test for negative values. Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com> Cc: Martin K. Petersen <martin.petersen@oracle.com> Cc: stable <stable@kernel.org> Assisted-by: gkh_clanker_2000 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by: Hannes Reinecke <hare@suse.de> Link: https://patch.msgid.link/2026022301-bony-overstock-a07f@gregkh Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent d1466bf commit c52df6a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/scsi/ses.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ static unsigned char *ses_get_page2_descriptor(struct enclosure_device *edev,
216216
unsigned char *type_ptr = ses_dev->page1_types;
217217
unsigned char *desc_ptr = ses_dev->page2 + 8;
218218

219-
if (ses_recv_diag(sdev, 2, ses_dev->page2, ses_dev->page2_len) < 0)
219+
if (ses_recv_diag(sdev, 2, ses_dev->page2, ses_dev->page2_len))
220220
return NULL;
221221

222222
for (i = 0; i < ses_dev->page1_num_types; i++, type_ptr += 4) {

0 commit comments

Comments
 (0)