Skip to content

Commit d1466bf

Browse files
LivelyCarpet87gregkh
authored andcommitted
scsi: ibmvfc: Fix OOB access in ibmvfc_discover_targets_done()
commit 61d099ac4a7a8fb11ebdb6e2ec8d77f38e77362f upstream. A malicious or compromised VIO server can return a num_written value in the discover targets MAD response that exceeds max_targets. This value is stored directly in vhost->num_targets without validation, and is then used as the loop bound in ibmvfc_alloc_targets() to index into disc_buf[], which is only allocated for max_targets entries. Indices at or beyond max_targets access kernel memory outside the DMA-coherent allocation. The out-of-bounds data is subsequently embedded in Implicit Logout and PLOGI MADs that are sent back to the VIO server, leaking kernel memory. Fix by clamping num_written to max_targets before storing it. Fixes: 072b91f ("[SCSI] ibmvfc: IBM Power Virtual Fibre Channel Adapter Client Driver") Reported-by: Yuhao Jiang <danisjiang@gmail.com> Cc: stable@vger.kernel.org Signed-off-by: Tyllis Xu <LivelyCarpet87@gmail.com> Reviewed-by: Dave Marquardt <davemarq@linux.ibm.com> Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com> Link: https://patch.msgid.link/20260314170151.548614-1-LivelyCarpet87@gmail.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 3699caf commit d1466bf

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/scsi/ibmvscsi/ibmvfc.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4963,7 +4963,8 @@ static void ibmvfc_discover_targets_done(struct ibmvfc_event *evt)
49634963
switch (mad_status) {
49644964
case IBMVFC_MAD_SUCCESS:
49654965
ibmvfc_dbg(vhost, "Discover Targets succeeded\n");
4966-
vhost->num_targets = be32_to_cpu(rsp->num_written);
4966+
vhost->num_targets = min_t(u32, be32_to_cpu(rsp->num_written),
4967+
max_targets);
49674968
ibmvfc_set_host_action(vhost, IBMVFC_HOST_ACTION_ALLOC_TGTS);
49684969
break;
49694970
case IBMVFC_MAD_FAILED:

0 commit comments

Comments
 (0)