Skip to content

Commit c4544ec

Browse files
authored
[UR][L0v2] Treat peers with statuses other than NO_CONNECTION as accessible for cross-device allocations (#22580)
Enables tests turned off in: #22077
1 parent 190878e commit c4544ec

7 files changed

Lines changed: 2 additions & 37 deletions

File tree

unified-runtime/source/adapters/level_zero/v2/context.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,8 @@ ur_context_handle_t_::getDevicesWhoseAllocationsCanBeAccessedFrom(
201201
"there is no device:"
202202
<< candidateId << " in peers table, number of devices:"
203203
<< peers.size());
204-
return peers[candidateId] == ur_device_handle_t_::PeerStatus::ENABLED;
204+
return peers[candidateId] !=
205+
ur_device_handle_t_::PeerStatus::NO_CONNECTION;
205206
});
206207

207208
return retVal;

unified-runtime/test/conformance/enqueue/urEnqueueMemBufferCopy.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,6 @@ UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urEnqueueMemBufferCopyMultiDeviceTest);
113113
TEST_P(urEnqueueMemBufferCopyMultiDeviceTest, CopyReadDifferentQueues) {
114114
UUR_KNOWN_FAILURE_ON(uur::CUDA{});
115115

116-
// Related issue: https://github.com/intel/llvm/issues/22058.
117-
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});
118-
119116
// First queue does a fill.
120117
const uint32_t input = 42;
121118
ASSERT_SUCCESS(urEnqueueMemBufferFill(

unified-runtime/test/conformance/enqueue/urEnqueueMemBufferCopyRect.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -311,9 +311,6 @@ UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urEnqueueMemBufferCopyRectMultiDeviceTest);
311311
TEST_P(urEnqueueMemBufferCopyRectMultiDeviceTest, CopyRectReadDifferentQueues) {
312312
UUR_KNOWN_FAILURE_ON(uur::CUDA{});
313313

314-
// Related issue: https://github.com/intel/llvm/issues/22058.
315-
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});
316-
317314
// First queue does a fill.
318315
const uint32_t input = 42;
319316
ASSERT_SUCCESS(urEnqueueMemBufferFill(

unified-runtime/test/conformance/enqueue/urEnqueueMemBufferFill.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,9 +212,6 @@ using urEnqueueMemBufferFillMultiDeviceTest =
212212
UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urEnqueueMemBufferFillMultiDeviceTest);
213213

214214
TEST_P(urEnqueueMemBufferFillMultiDeviceTest, FillReadDifferentQueues) {
215-
// Related issue: https://github.com/intel/llvm/issues/22058.
216-
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});
217-
218215
// First queue does a fill.
219216
const uint32_t input = 42;
220217
ASSERT_SUCCESS(urEnqueueMemBufferFill(

unified-runtime/test/conformance/enqueue/urEnqueueMemBufferRead.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,6 @@ using urEnqueueMemBufferReadMultiDeviceTest =
138138
UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urEnqueueMemBufferReadMultiDeviceTest);
139139

140140
TEST_P(urEnqueueMemBufferReadMultiDeviceTest, WriteReadDifferentQueues) {
141-
// Related issue: https://github.com/intel/llvm/issues/22058.
142-
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});
143-
144141
// First queue does a blocking write of 42 into the buffer.
145142
std::vector<uint32_t> input(count, 42);
146143
ASSERT_SUCCESS(urEnqueueMemBufferWrite(queues[0], buffer, true, 0, size,

unified-runtime/test/conformance/enqueue/urEnqueueMemBufferReadRect.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -277,9 +277,6 @@ UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urEnqueueMemBufferReadRectMultiDeviceTest);
277277

278278
TEST_P(urEnqueueMemBufferReadRectMultiDeviceTest,
279279
WriteRectReadDifferentQueues) {
280-
// Related issue: https://github.com/intel/llvm/issues/22058.
281-
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});
282-
283280
// First queue does a blocking write of 42 into the buffer.
284281
// Then a rectangular write the buffer as 1024x1x1 1D.
285282
std::vector<uint32_t> input(count, 42);

unified-runtime/test/conformance/memory-migrate/urMemBufferMigrateAcrossDevices.cpp

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,6 @@ struct urMultiDeviceContextMemBufferTest : urMultiDeviceContextTest {
177177
UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urMultiDeviceContextMemBufferTest);
178178

179179
TEST_P(urMultiDeviceContextMemBufferTest, WriteRead) {
180-
// Related issue: https://github.com/intel/llvm/issues/22058.
181-
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});
182-
183180
if (num_devices <= 1) {
184181
GTEST_SKIP();
185182
}
@@ -204,9 +201,6 @@ TEST_P(urMultiDeviceContextMemBufferTest, WriteRead) {
204201
}
205202

206203
TEST_P(urMultiDeviceContextMemBufferTest, FillRead) {
207-
// Related issue: https://github.com/intel/llvm/issues/22058.
208-
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});
209-
210204
if (num_devices <= 1) {
211205
GTEST_SKIP();
212206
}
@@ -231,9 +225,6 @@ TEST_P(urMultiDeviceContextMemBufferTest, FillRead) {
231225
}
232226

233227
TEST_P(urMultiDeviceContextMemBufferTest, WriteKernelRead) {
234-
// Related issue: https://github.com/intel/llvm/issues/22058.
235-
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});
236-
237228
if (num_devices <= 1) {
238229
GTEST_SKIP();
239230
}
@@ -271,9 +262,6 @@ TEST_P(urMultiDeviceContextMemBufferTest, WriteKernelRead) {
271262
}
272263

273264
TEST_P(urMultiDeviceContextMemBufferTest, WriteKernelKernelRead) {
274-
// Related issue: https://github.com/intel/llvm/issues/22058.
275-
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});
276-
277265
if (num_devices <= 1) {
278266
GTEST_SKIP();
279267
}
@@ -317,9 +305,6 @@ TEST_P(urMultiDeviceContextMemBufferTest, WriteKernelKernelRead) {
317305
}
318306

319307
TEST_P(urMultiDeviceContextMemBufferTest, PingPongKernelExecution) {
320-
// Related issue: https://github.com/intel/llvm/issues/22058.
321-
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});
322-
323308
if (num_devices <= 1) {
324309
GTEST_SKIP();
325310
}
@@ -368,9 +353,6 @@ TEST_P(urMultiDeviceContextMemBufferTest, PingPongKernelExecution) {
368353
}
369354

370355
TEST_P(urMultiDeviceContextMemBufferTest, ComplexMigrationPattern) {
371-
// Related issue: https://github.com/intel/llvm/issues/22058.
372-
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});
373-
374356
if (num_devices <= 1) {
375357
GTEST_SKIP();
376358
}
@@ -437,9 +419,6 @@ TEST_P(urMultiDeviceContextMemBufferTest, ComplexMigrationPattern) {
437419
}
438420

439421
TEST_P(urMultiDeviceContextMemBufferTest, KernelsExecutionWithThreads) {
440-
// Related issue: https://github.com/intel/llvm/issues/22058.
441-
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});
442-
443422
if (num_devices <= 1) {
444423
GTEST_SKIP();
445424
}

0 commit comments

Comments
 (0)