[SYCL] Add prototype of sycl_khr_group_interface#15617
Closed
Pennycook wants to merge 4 commits intointel:syclfrom
Closed
[SYCL] Add prototype of sycl_khr_group_interface#15617Pennycook wants to merge 4 commits intointel:syclfrom
Pennycook wants to merge 4 commits intointel:syclfrom
Conversation
Adds khr::work_group, khr::sub_group and khr::work_item classes, khr::get_item() and khr::leader_of() free-functions, and basic tests. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Pennycook
added
the
spec extension
Pennycook
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Pennycook
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Pennycook
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Pennycook
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Functionality guarded by __DPCPP_ENABLE_UNFINISHED_KHR_EXTENSIONS, following the process introduced by intel#16883. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Pennycook
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Pennycook
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| sub_group g = item.get_sub_group(); | ||
|
|
||
| khr::sub_group sg = g; | ||
| assert(sg.id() == g.get_group_id()); |
Contributor
There was a problem hiding this comment.
I'm not very confident in using device asserts for our tests... Does anybody know for sure it's stable enough?
Contributor
Author
|
This was re-implemented in #17595, so this can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
khr::work_group,khr::sub_groupandkhr::work_itemclasses,khr::get_item()andkhr::leader_of()free-functions, and basic tests.This is being developed in conjunction with the extension specification (KhronosGroup/SYCL-Docs#638).