Skip to content

Implement the sycl_khr_group_interface extension#17595

Merged
AlexeySachkov merged 15 commits intointel:syclfrom
0x12CC:sycl_khr_group_interface
May 12, 2025
Merged

Implement the sycl_khr_group_interface extension#17595
AlexeySachkov merged 15 commits intointel:syclfrom
0x12CC:sycl_khr_group_interface

Conversation

@0x12CC
Copy link
Copy Markdown
Contributor

@0x12CC 0x12CC commented Mar 23, 2025

No description provided.

0x12CC added 5 commits March 23, 2025 15:47
@0x12CC
Implement sycl_khr_group_interface
1375714 
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC
Fix minor issues in extension header
62d512a 
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC
Rename khr::work_item to khr::member_item
fac4f4a 
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC
Rename khr::get_item to khr::get_member_item
820994f 
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC
Update test cases
a93b3d1 
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC 0x12CC requested a review from a team as a code owner March 23, 2025 23:09
@0x12CC 0x12CC temporarily deployed to WindowsCILock March 23, 2025 23:09 — with GitHub Actions Inactive
@0x12CC 0x12CC temporarily deployed to WindowsCILock March 23, 2025 23:43 — with GitHub Actions Inactive
@0x12CC 0x12CC temporarily deployed to WindowsCILock March 23, 2025 23:43 — with GitHub Actions Inactive
@KornevNikita
Copy link
Copy Markdown
Contributor

KornevNikita commented Mar 24, 2025

@0x12CC could you please attach an extension link?

AlexeySachkov
AlexeySachkov reviewed Mar 24, 2025
View reviewed changes
Comment thread sycl/include/sycl/khr/group_interface.hpp Outdated
Comment thread sycl/test-e2e/GroupInterface/leader_of.cpp Outdated
Comment thread sycl/test-e2e/GroupInterface/sub_group.cpp
Comment thread sycl/test-e2e/GroupInterface/work_group.cpp Outdated
@Pennycook Pennycook mentioned this pull request Mar 24, 2025
Merged
dyniols
dyniols reviewed Mar 26, 2025
View reviewed changes
Comment thread sycl/include/sycl/sycl.hpp Outdated
0x12CC added 4 commits March 27, 2025 08:27
@0x12CC
Remove uses of std::ignore
5fdeeb8 
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC
Remove test pass output
e0f4e93 
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC
Use accessor instead of device-side assert
cc9f060 
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC
Merge branch 'sycl' into sycl_khr_group_interface
10c2770 
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC
Copy link
Copy Markdown
Contributor Author

0x12CC commented Mar 27, 2025

@AlexeySachkov, thanks for the review. I've addressed all your comments.

@KornevNikita, the extension hasn't been merged but is in KhronosGroup/SYCL-Docs#638.

@0x12CC
Run clang-format
0e25492 
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC 0x12CC temporarily deployed to WindowsCILock March 27, 2025 15:38 — with GitHub Actions Inactive
@0x12CC
Fix work_group test case
c55803b 
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC 0x12CC temporarily deployed to WindowsCILock March 31, 2025 19:29 — with GitHub Actions Inactive
@0x12CC 0x12CC temporarily deployed to WindowsCILock March 31, 2025 20:27 — with GitHub Actions Inactive
@0x12CC 0x12CC temporarily deployed to WindowsCILock March 31, 2025 20:27 — with GitHub Actions Inactive
dyniols
dyniols approved these changes Apr 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dyniols dyniols left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Regarding moving all khr extensions to common directory I guess it can be done in another PR after this one has been merged.
#17595 (comment)

KseniyaTikhomirova
KseniyaTikhomirova reviewed Apr 7, 2025
View reviewed changes
Comment thread sycl/include/sycl/khr/group_interface.hpp Outdated
Comment thread sycl/include/sycl/khr/group_interface.hpp
Comment thread sycl/test-e2e/GroupInterface/work_group.cpp
AlexeySachkov
AlexeySachkov reviewed Apr 17, 2025
View reviewed changes
Comment thread sycl/include/sycl/sycl.hpp
0x12CC added 3 commits April 29, 2025 13:21
@0x12CC
Merge branch 'sycl' into sycl_khr_group_interface
534a756 
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC
Address review comments
868abc1 
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC
Merge branch 'sycl' into sycl_khr_group_interface
5ba5c91 
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC 0x12CC temporarily deployed to WindowsCILock May 2, 2025 19:21 — with GitHub Actions Inactive
@0x12CC 0x12CC temporarily deployed to WindowsCILock May 2, 2025 19:57 — with GitHub Actions Inactive
@0x12CC 0x12CC temporarily deployed to WindowsCILock May 2, 2025 20:08 — with GitHub Actions Inactive
@0x12CC
Merge branch 'sycl' into sycl_khr_group_interface
e76144b 
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC 0x12CC temporarily deployed to WindowsCILock May 7, 2025 20:13 — with GitHub Actions Inactive
@0x12CC 0x12CC temporarily deployed to WindowsCILock May 7, 2025 20:39 — with GitHub Actions Inactive
@0x12CC 0x12CC temporarily deployed to WindowsCILock May 7, 2025 20:39 — with GitHub Actions Inactive
@0x12CC
Copy link
Copy Markdown
Contributor Author

0x12CC commented May 8, 2025

@KseniyaTikhomirova, @AlexeySachkov, friendly ping.

I'm looking into the following test failures but I don't believe they're related to my changes:

********************
Failed Tests (2):
  SYCL :: ThreadSanitizer/check_device_global.cpp
  SYCL :: ThreadSanitizer/check_usm.cpp

Otherwise, this PR is ready for review. Please let me know if you'd like me to make any other changes.

@KornevNikita
Copy link
Copy Markdown
Contributor

KornevNikita commented May 9, 2025

@KseniyaTikhomirova, @AlexeySachkov, friendly ping.

I'm looking into the following test failures but I don't believe they're related to my changes:

********************
Failed Tests (2):
  SYCL :: ThreadSanitizer/check_device_global.cpp
  SYCL :: ThreadSanitizer/check_usm.cpp

Otherwise, this PR is ready for review. Please let me know if you'd like me to make any other changes.

#18349

KseniyaTikhomirova
KseniyaTikhomirova approved these changes May 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@KseniyaTikhomirova KseniyaTikhomirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexeySachkov AlexeySachkov merged commit 713a9dd into intel:sycl May 12, 2025
19 of 20 checks passed
@0x12CC 0x12CC deleted the sycl_khr_group_interface branch May 12, 2025 13:39
@dyniols dyniols mentioned this pull request May 20, 2025
Merged
sarnex pushed a commit that referenced this pull request May 20, 2025
@dyniols
[SYCL][NFC] Move khr_free_function_commands extension to common khr…
ccb079c 
… directory (#18556)

Purpose of this PR is to move `khr_free_function_commands` extension to
common `khr` directory based on discussion
#17595 (comment)
Extension spec: KhronosGroup/SYCL-Docs#644
@0x12CC 0x12CC mentioned this pull request Jun 9, 2025
Merged
@Pennycook Pennycook mentioned this pull request Jul 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pennycook Pennycook Pennycook left review comments

@dyniols dyniols dyniols approved these changes

@KseniyaTikhomirova KseniyaTikhomirova KseniyaTikhomirova approved these changes

+1 more reviewer

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@0x12CC @KornevNikita @Pennycook @AlexeySachkov @KseniyaTikhomirova @dyniols