[UR][L0] Add L0 teardown notification support and simply teardown with proxy loader support#18496
Conversation
nrspruit
commented
May 15, 2025
- Add support for L0 teardown notification in the static L0 loader.
- Add loading of the L0 dynamic loader in the windows proxy loader to ensure that the L0 dynamic loader is usable during teardown.
|
related to oneapi-src/level-zero#333 |
8f1f54e to
a21160d
Compare
a21160d to
ecefdbe
Compare
|
@nrspruit - the test failures reported here seem legit. But they are strange. The The The test failed on Arc, I think. But I can repro the failure on pvc-01. |
ecefdbe to
df6d57d
Compare
that error has existed since before this change, so it may be a real issue, but it is not part of this PR. See here: |
|
Test failures are known: #18463 |
df6d57d to
7229f1d
Compare
|
I assume this PR has some sort of merge problem? Seems like a lot of unrelated things changed. |
the rebase failed, let me fix |
…h proxy loader support - Add support for L0 teardown notification in the static L0 loader. - Add loading of the L0 dynamic loader in the windows proxy loader to ensure that the L0 dynamic loader is usable during teardown. Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
7229f1d to
0987d29
Compare
fixed, for some reason the pulldown was included with I rebased. |
| loadAdapter(UR_LIBRARY_NAME(adapter_native_cpu)); | ||
| // Load the Level Zero loader dynamic library to ensure it is loaded during | ||
| // the runtime. This is necessary to avoid the level zero loader from being | ||
| // unloaded prematurely. the Only trusted loader is the one that is loaded |
There was a problem hiding this comment.
| // unloaded prematurely. the Only trusted loader is the one that is loaded | |
| // unloaded prematurely. The only trusted loader is the one that is loaded |
There was a problem hiding this comment.
I guess cuda reviewers were pulled in because of the rebase problem, but still, LGTM :)
|
@intel/llvm-gatekeepers , please merge when available, this enables usage of an improved short term and long term solution to the teardown issues in SYCL when using L0. |
…h proxy loader support (#18496) - Add support for L0 teardown notification in the static L0 loader. - Add loading of the L0 dynamic loader in the windows proxy loader to ensure that the L0 dynamic loader is usable during teardown. Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>