Skip to content

[UR][L0] Add L0 teardown notification support and simply teardown with proxy loader support #18496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarnex merged 1 commit into from
May 19, 2025
Merged

[UR][L0] Add L0 teardown notification support and simply teardown with proxy loader support #18496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sycl/ur_win_proxy_loader/ur_win_proxy_loader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,11 @@ void preloadLibraries() {
loadAdapter(UR_LIBRARY_NAME(adapter_cuda));
loadAdapter(UR_LIBRARY_NAME(adapter_hip));
loadAdapter(UR_LIBRARY_NAME(adapter_native_cpu));
// Load the Level Zero loader dynamic library to ensure it is loaded during
// the runtime. This is necessary to avoid the level zero loader from being
// unloaded prematurely. the Only trusted loader is the one that is loaded

@jchlanda jchlanda May 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// unloaded prematurely. the Only trusted loader is the one that is loaded
// unloaded prematurely. The only trusted loader is the one that is loaded

@jchlanda jchlanda May 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess cuda reviewers were pulled in because of the rebase problem, but still, LGTM :)

// from the system32 directory.
LoadLibraryExW(L"ze_loader.dll", NULL, LOAD_LIBRARY_SEARCH_SYSTEM32);

// Restore system error handling.
(void)SetErrorMode(SavedMode);
Expand Down
2 changes: 1 addition & 1 deletion unified-runtime/cmake/FetchLevelZero.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ if (NOT DEFINED LEVEL_ZERO_LIBRARY OR NOT DEFINED LEVEL_ZERO_INCLUDE_DIR)
set(UR_LEVEL_ZERO_LOADER_REPO "https://github.com/oneapi-src/level-zero.git")
endif()
if (UR_LEVEL_ZERO_LOADER_TAG STREQUAL "")
set(UR_LEVEL_ZERO_LOADER_TAG abc68a57e5d536a449a5e45f1aef85285fa70088)
set(UR_LEVEL_ZERO_LOADER_TAG 35c037cdf4aa9a2e6df34b6f1ce1bdc86ac5422f)
endif()

# Disable due to a bug https://github.com/oneapi-src/level-zero/issues/104
Expand Down