[SYCL][NFC] Move khr_free_function_commands extension to common khr directory#18556
Merged
sarnex merged 1 commit intointel:syclfrom May 20, 2025
Merged
Conversation
uditagarwal97
approved these changes
May 20, 2025
Contributor
uditagarwal97
left a comment
uditagarwal97
left a comment
There was a problem hiding this comment.
LGTM. Can we also add a [NFC] tag in the title of the PR, since it's a non-functional change?
0x12CC
approved these changes
May 20, 2025
Contributor
Author
Sure |
dyniols
changed the title
khr_free_function_commands extension to common khr directorykhr_free_function_commands extension to common khr directory
Contributor
Author
|
@intel/llvm-gatekeepers Can we merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR is to move
khr_free_function_commandsextension to commonkhrdirectory based on discussion #17595 (comment)Extension spec: KhronosGroup/SYCL-Docs#644