Skip to content

[NFC][SYCL][E2E] Split long tests#21862

Draft
bratpiorka wants to merge 3 commits into
intel:syclfrom
bratpiorka:rrudnick_split
Draft

[NFC][SYCL][E2E] Split long tests#21862
bratpiorka wants to merge 3 commits into
intel:syclfrom
bratpiorka:rrudnick_split

Conversation

@bratpiorka

@bratpiorka bratpiorka commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

This PR splits a long‑running test that could time out on slower machines (e.g. new system used for testing CUDA 13):

  • sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_1d.cpp
  • sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_2d_common.hpp
  • sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_write_1d_unsampled_common.hpp
  • sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_write_2d_unsampled_common.hpp
  • sycl/test-e2e/bindless_images/read_sampled_common.hpp
  • sycl/test-e2e/WorkGroupMemory/basic_usage_common.hpp

@bratpiorka bratpiorka force-pushed the rrudnick_split branch 6 times, most recently from b7801bd to cdc6e25 Compare April 24, 2026 08:00
@bratpiorka bratpiorka changed the title [WIP] split [NFC][SYCL][E2E] Split long tests Apr 24, 2026
@bratpiorka bratpiorka marked this pull request as ready for review April 24, 2026 08:03
@bratpiorka bratpiorka requested review from a team as code owners April 24, 2026 08:03
@uditagarwal97 uditagarwal97 requested a review from Copilot April 24, 2026 09:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR splits several long-running SYCL E2E tests into smaller, more focused binaries to reduce timeout risk on slower test machines.

Changes:

  • Split Vulkan/SYCL bindless image interop read/write tests into channel/sample/semaphore-focused test entrypoints.
  • Split sampled image read tests into separate 1D and 2D entrypoints, moving shared logic into a common implementation.
  • Split WorkGroupMemory “basic usage” coverage into separate pointer vs non-pointer entrypoints, moving shared logic into a common implementation.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_write_2d_unsampled_semaphores.cpp New semaphore-focused 2D unsampled write test entrypoint including shared implementation.
sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_write_2d_unsampled_channels.cpp New channel-matrix 2D unsampled write test entrypoint including shared implementation.
sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_write_2d_unsampled.cpp Converts former monolithic test into shared implementation (header-like) used by new entrypoints.
sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_write_1d_unsampled_semaphores.cpp New semaphore-focused 1D unsampled write test entrypoint including shared implementation.
sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_write_1d_unsampled_channels.cpp New channel-matrix 1D unsampled write test entrypoint including shared implementation.
sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_write_1d_unsampled.cpp Converts former monolithic test into shared implementation (header-like) used by new entrypoints.
sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_2d_semaphores.cpp New semaphore-focused 2D read test entrypoint including shared implementation.
sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_2d_sampled.cpp New sampled-only 2D read test entrypoint including shared implementation.
sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_2d_channels.cpp New unsampled channel-matrix 2D read test entrypoint including shared implementation.
sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_2d.cpp Converts former monolithic test into shared implementation (header-like) used by new entrypoints.
sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_1d_semaphores.cpp New semaphore-focused 1D read test entrypoint including shared implementation.
sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_1d_sampled.cpp New sampled-only 1D read test entrypoint including shared implementation.
sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_1d_channels.cpp New unsampled channel-matrix 1D read test entrypoint including shared implementation.
sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_1d.cpp Converts former monolithic test into shared implementation (header-like) used by new entrypoints.
sycl/test-e2e/bindless_images/read_sampled_2d.cpp New 2D-only sampled image read test entrypoint calling shared helpers.
sycl/test-e2e/bindless_images/read_sampled_1d.cpp New 1D-only sampled image read test entrypoint calling shared helpers.
sycl/test-e2e/bindless_images/read_sampled.cpp Converts former monolithic sampled read test into shared implementation with reusable runAll1D/runAll2D.
sycl/test-e2e/WorkGroupMemory/basic_usage_test_ptr.cpp New pointer-types WorkGroupMemory basic usage test entrypoint including shared helpers.
sycl/test-e2e/WorkGroupMemory/basic_usage_test.cpp New non-pointer WorkGroupMemory basic usage test entrypoint including shared helpers.
sycl/test-e2e/WorkGroupMemory/basic_usage.cpp Converts former monolithic WorkGroupMemory test into shared implementation (header-like) used by new entrypoints.

Comment thread sycl/test-e2e/WorkGroupMemory/basic_usage_test.cpp Outdated
Comment thread sycl/test-e2e/bindless_images/read_sampled_1d.cpp Outdated
@bratpiorka

Copy link
Copy Markdown
Contributor Author

@uditagarwal97 applied copilot suggesions

@bratpiorka bratpiorka marked this pull request as draft May 15, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants