Skip to content

[UR][L0] Fix event refcount bugs in L0 v1 adapter barrier handling #21871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
winstonzhang-intel wants to merge 1 commit into
base: sycl
Choose a base branch
from
+8 −11
Open

[UR][L0] Fix event refcount bugs in L0 v1 adapter barrier handling #21871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions unified-runtime/source/adapters/level_zero/event.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,10 @@ ur_result_t urEnqueueEventsWaitWithBarrierExt(
[&Queue](ur_command_list_ptr_t CmdList, ur_ze_event_list_t &EventWaitList,
ur_event_handle_t &Event, bool IsInternal,
bool InterruptBasedEventsEnabled) {
(void)InterruptBasedEventsEnabled;
UR_CALL(createEventAndAssociateQueue(
Queue, &Event, UR_COMMAND_EVENTS_WAIT_WITH_BARRIER, CmdList,
IsInternal, InterruptBasedEventsEnabled));
IsInternal, /* IsMultiDevice */ false));

Event->WaitList = EventWaitList;

Expand Down Expand Up @@ -795,7 +796,7 @@ urEventWait(uint32_t NumEvents,
//
ur_event_handle_t_ *Event = ur_cast<ur_event_handle_t_ *>(e);
if (!Event->hasExternalRefs())
die("urEventWait must not be called for an internal event");
continue;
Copy link
Copy Markdown
Contributor

@kswiecicki kswiecicki Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is urEventWait must not be called for an internal event no longer valid?


ze_event_handle_t ZeHostVisibleEvent;
if (auto Res = Event->getOrCreateHostVisibleEvent(ZeHostVisibleEvent))
Expand All @@ -821,7 +822,7 @@ urEventWait(uint32_t NumEvents,
{
std::shared_lock<ur_shared_mutex> EventLock(Event->Mutex);
if (!Event->hasExternalRefs())
die("urEventWait must not be called for an internal event");
continue;

if (!Event->Completed) {
auto HostVisibleEvent = Event->HostVisibleEvent;
Expand Down Expand Up @@ -893,15 +894,11 @@ urEventRelease(/** [in] handle of the event object */ ur_event_handle_t Event) {
UR_CALL(urEventReleaseInternal(Event, &isEventDeleted));
// If this is a Completed Event Wait Out Event, then we need to cleanup the
// event at user release and not at the time of completion.
// If the event is labelled as completed and no additional references are
// removed, then we still need to decrement the event, but not mark as
// completed.
// Use CleanupCompletedEvent which is a no-op if the event was already
// cleaned up (e.g. by CleanupEventListFromResetCmdList), preventing a
// double-release of the internal reference count.
if (isEventsWaitCompleted & !isEventDeleted) {
if (Event->CleanedUp) {
UR_CALL(urEventReleaseInternal(Event));
} else {
UR_CALL(CleanupCompletedEvent((Event), false, false));
}
UR_CALL(CleanupCompletedEvent((Event), false, false));
}

return UR_RESULT_SUCCESS;
Expand Down
Loading