[SYCL] Clarify cache_config as a kernel launch property#21872
Open
againull wants to merge 1 commit intointel:syclfrom
Open
[SYCL] Clarify cache_config as a kernel launch property#21872againull wants to merge 1 commit intointel:syclfrom
againull wants to merge 1 commit intointel:syclfrom
Conversation
Update the sycl_ext_intel_cache_config specification to state explicitly that cache_config is a runtime kernel launch property: it must be passed to the kernel invocation via launch_config and must not be embedded in a kernel functor via get(properties_tag). It looks like property-list overloads for single_task/parallel_for are deprecated, so I have removed those from examples in the extension doc. Instead added examples with launch_config. Also fixed line wrapping to 80 columns. Updated e2e test accordingly and added test cases for the enqueue free functions (parallel_for, nd_launch) from sycl_ext_oneapi_enqueue_functions with a launch_config (including free function kernel case). Kept coverage for deprecated APIs (just removed embeddings into kernel type).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the sycl_ext_intel_cache_config specification to state explicitly that cache_config is a runtime kernel launch property: it must be passed to the kernel invocation via launch_config and must not be embedded in a kernel functor via get(properties_tag).
It looks like property-list overloads for single_task/parallel_for are deprecated, so I have removed those from examples in the extension doc. Instead added examples with launch_config.
Also fixed line wrapping to 80 columns.
Updated e2e test accordingly and added test cases for the enqueue free functions (parallel_for, nd_launch) from sycl_ext_oneapi_enqueue_functions with a launch_config (including free function kernel case). Kept coverage for deprecated APIs (just removed embeddings into kernel type).
Assisted-by: Claude