[SYCL] Remove deprecated sub_group::load and sub_group::store#21875
Merged
againull merged 3 commits intointel:syclfrom Apr 27, 2026
Merged
[SYCL] Remove deprecated sub_group::load and sub_group::store#21875againull merged 3 commits intointel:syclfrom
againull merged 3 commits intointel:syclfrom
Conversation
These methods were deprecated in intel#15405 in favor of sycl::ext::oneapi::experimental::group_load/group_store. Moved deprecated group_load_store spec to removed.
slawekptak
approved these changes
Apr 27, 2026
dkhaldi
reviewed
Apr 27, 2026
YuriPlyakhin
approved these changes
Apr 27, 2026
Contributor
YuriPlyakhin
left a comment
YuriPlyakhin
left a comment
There was a problem hiding this comment.
spec file move LGTM
Contributor
|
I'm very happy to remove this, but I thought we were not able to remove APIs in a minor release. I vaguely remember there being a special case, though. Was it this API that we decided to remove because it had been deprecated so long and because we forgot to remove it in the last major release? |
Contributor
Author
Yes, that's correct, it was decided to remove this API as an exception. |
gmlueck
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods were deprecated in #15405 in favor of sycl::ext::oneapi::experimental::group_load/group_store.
Moved deprecated group_load_store spec to removed.