[SYCL][Graph] Allow capturing restricted host tasks in native recording mode by adamfidel · Pull Request #22143 · intel/llvm

adamfidel · 2026-05-27T19:53:18Z

This PR allows SYCL Graph native recording mode to capture the new restricted host task defined in the sycl_ext_oneapi_enqueue_functions extension.

…ng mode

…d commands Move EnqueueHostTaskData and NativeHostTask from the anonymous namespace in commands.cpp into host_task.hpp so both the native recording path in handler.cpp and the scheduler path in commands.cpp use the same type and callback rather than duplicating the pattern. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

mmichel11

Small feedback about proper handling with older driver versions.

mmichel11

Graph changes LGTM

slawekptak

Please note this PR: #22518 . It changes the implementation of native host tasks (new command type). I think it is not an issue, and depending on which PR is merged first, the other one just needs to be updated, but I'm sharing it just in case. It would be great if you could take a look at that one and make sure there are no issues. Thanks.

slawekptak · 2026-07-08T12:17:52Z

One more question - is recording of restricted host tasks (enqueue_functions) supported today, but for a non-native graph recording mode?

adamfidel · 2026-07-08T14:27:45Z

One more question - is recording of restricted host tasks (enqueue_functions) supported today, but for a non-native graph recording mode?

Yes, this PR introduces two tests for restricted host tasks: one for native recording mode and one for the original command buffer mode.

adamfidel · 2026-07-08T14:46:53Z

Please note this PR: #22518 . It changes the implementation of native host tasks (new command type). I think it is not an issue, and depending on which PR is merged first, the other one just needs to be updated, but I'm sharing it just in case. It would be great if you could take a look at that one and make sure there are no issues. Thanks.

Thanks for sharing this. I took a look and your PR is a nice cleanup and I agree that making a native host task its own node type is a nice way to organize it. It looks like our PRs touch a lot of the same things and while don't think it will be a problem to incorporate these two PRs conceptually, I anticipate that it would be a problem in terms of actually reconciling the text diffs.

But overall I think your PR is a good rework of the native host task feature.

Copilot

Pull request overview

This PR enables SYCL Graph native recording mode to capture restricted host tasks submitted via the sycl_ext_oneapi_enqueue_functions extension, aligning native recording behavior with the newer enqueue-functions host task API. It does so by bypassing the scheduler for eligible host tasks during recording and directly enqueueing the backend host-task callback into the native graph capture.

Changes:

Allow restricted host tasks to be recorded in native recording mode by enqueueing urEnqueueHostTaskExp from handler::finalize() and retaining callback lifetime via graph_impl.
Centralize native host-task callback plumbing (EnqueueHostTaskData, NativeHostTask<>, and host-task functor extraction) in detail/host_task.hpp, and update scheduler host-task dispatch to use it.
Add E2E coverage for both command-buffer and native-recording record/replay paths, and update the Graph extension documentation to reflect the new support.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
sycl/test-e2e/Graph/RecordReplay/NativeRecording/enqueue_func_host_task.cpp	Adds a native-recording-specific E2E test wrapper enabling native recording for the shared test logic.
sycl/test-e2e/Graph/RecordReplay/Inputs/enqueue_func_host_task.cpp	Shared E2E test logic validating restricted host task recording/replay semantics across two replays.
sycl/test-e2e/Graph/RecordReplay/enqueue_func_host_task.cpp	Adds command-buffer-path E2E coverage for restricted host task recording via the Record & Replay path.
sycl/source/handler.cpp	Implements native-recording host-task capture path: validates restricted host task + backend support, stores callback data in the graph, enqueues UR host task, and returns a completed host event during recording.
sycl/source/detail/scheduler/commands.cpp	Removes local native-host-task callback helpers and switches to the shared `detail/host_task.hpp` implementation.
sycl/source/detail/host_task.hpp	Introduces shared native-host-task callback data + callback function template, and exposes host-task functor extraction via `HandlerAccess`.
sycl/source/detail/graph/graph_impl.hpp	Adds API and storage to own callback data for host tasks recorded in native recording mode.
sycl/source/detail/graph/graph_impl.cpp	Implements `graph_impl::addNativeHostTaskCallback()` to retain native host-task callback payloads for UR.
sycl/include/sycl/handler.hpp	Declares `HandlerAccess::getHostTaskFunc()` to support internal extraction of host-task functors.
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc	Documents the native-recording limitation for `handler::host_task` and the supported restricted host-task path via enqueue-functions.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…ifetime needs to be managed by graph)

adamfidel · 2026-07-09T15:17:43Z

@intel/llvm-gatekeepers Please consider merging :)

adamfidel force-pushed the adam/host-task-native-recording branch from 25ba6de to 1e41cd9 Compare May 28, 2026 16:39

adamfidel marked this pull request as ready for review May 28, 2026 19:10

adamfidel requested review from a team as code owners May 28, 2026 19:10

adamfidel requested review from mmichel11 and slawekptak May 28, 2026 19:10

mmichel11 reviewed May 28, 2026

View reviewed changes

Comment thread sycl/source/handler.cpp Outdated

Comment thread sycl/source/detail/host_task.hpp Outdated

Comment thread sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc

mmichel11 reviewed May 29, 2026

View reviewed changes

Comment thread sycl/source/handler.cpp Outdated

adamfidel requested a review from a team as a code owner May 29, 2026 22:40

adamfidel marked this pull request as draft May 29, 2026 22:42

adamfidel and others added 11 commits June 4, 2026 13:57

[SYCL][Graph] Allow capturing restricted host tasks in native recordi…

7dbbe26

…ng mode

Code formatting

0ac8e64

Update spec

c9c47e3

Unsupported reason

9b22de0

Clang format

50b1803

Store callbacks in graph to manage lifetime

ba854ed

Grab native handle using urQueueGetGraphExp directly

915bf80

Move UR calls out of finalize

e03ece2

Rewrite test to replay the graph twice

fff50cb

Add test for restricted host tasks in the non-native path

e1b75fd

adamfidel force-pushed the adam/host-task-native-recording branch from 5cfa113 to e1b75fd Compare June 4, 2026 20:59

adamfidel marked this pull request as ready for review June 4, 2026 21:23

clang-format

a212408

mmichel11 reviewed Jun 4, 2026

View reviewed changes

adamfidel added 2 commits June 26, 2026 12:35

Address review comments

f64c393

remove UR changes that were needed for old driver

8084c89

mmichel11 reviewed Jun 30, 2026

View reviewed changes

Comment thread sycl/test-e2e/Graph/RecordReplay/NativeRecording/enqueue_func_host_task.cpp Outdated

Comment thread sycl/source/handler.cpp

kswiecicki approved these changes Jul 2, 2026

View reviewed changes

Align test's REQUIRES directives to match get_graph_single_queue

53b9dbb

Add nullptr check for native graph

950b836

mmichel11 approved these changes Jul 6, 2026

View reviewed changes

slawekptak reviewed Jul 8, 2026

View reviewed changes

Comment thread sycl/source/handler.cpp Outdated

Comment thread sycl/source/handler.cpp

update comment describing native recording / host task path

dc2d812

Add TODO for checkDeviceSupports

4642abf

slawekptak requested a review from Copilot July 8, 2026 15:15

Copilot started reviewing on behalf of slawekptak July 8, 2026 15:15 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Comment thread sycl/source/handler.cpp Outdated

Comment thread sycl/source/handler.cpp Outdated

Comment thread sycl/source/handler.cpp Outdated

Comment thread sycl/source/detail/scheduler/commands.cpp

Comment thread sycl/source/detail/graph/graph_impl.hpp Outdated

Apply suggestions from Copilot

97b65cc

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

slawekptak approved these changes Jul 9, 2026

View reviewed changes

adamfidel added 2 commits July 9, 2026 07:14

clang-format

564766a

Revert suggestion from Copilot which incorrectly moved the functor (l…

093985f

…ifetime needs to be managed by graph)

sarnex merged commit b32d8e4 into intel:sycl Jul 9, 2026
31 checks passed

Uh oh!

Conversation

adamfidel commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mmichel11 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mmichel11 left a comment

Choose a reason for hiding this comment

Uh oh!

slawekptak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

slawekptak commented Jul 8, 2026

Uh oh!

adamfidel commented Jul 8, 2026

Uh oh!

adamfidel commented Jul 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adamfidel commented Jul 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

adamfidel commented May 27, 2026 •

edited

Loading