Conversation
Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
|
thanks! |
I thought we run both pre-commit and post-commit windows test in pulldown as well. Why these were not caught? |
|
It doesn't look like postcommit ran: https://github.com/intel/llvm/pull/22592/checks I will try to find out why and fix it. |
Thanks! I remembered that we did run post-commit testing before, it must be a regression in workflow. It would be great if we can confirm. |
|
I made #22627, I looked at the git history for the workflow and didn't notice anything that could have broken it, maybe I missed it. |
We need to run postcommit in pulldown PRs. In this PR the job is running twice, once for the `push` action and once for `pull_request` since we modified the postcommit workflow, but in a normal pulldown won't happen. We can't use the `pull_request` action because GitHub requires both `branches` and `paths` to be satisfied which won't be true for a normal pulldown. See #22620 Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
3 participants
These two
check-llvmtests are failing after the pulldown, see #22619.Example run: https://github.com/intel/llvm/actions/runs/29276755185/job/86907774799