[UR][L0] Disable USM residency P2P restriction by default - #22796
Open
ldorau wants to merge 1 commit into
Open
Conversation
ldorau
force-pushed
the
URL0_Disable_USM_residency_P2P_restriction_by_default
branch
from
July 29, 2026 09:51
531952b to
fd450f2
Compare
ldorau
marked this pull request as ready for review
July 29, 2026 10:04
Contributor
Author
|
Please review @intel/dpcpp-doc-reviewers, @intel/llvm-reviewers-runtime, and/or @intel/unified-runtime-reviewers-level-zero. |
pbalcer
reviewed
Jul 29, 2026
pbalcer
approved these changes
Jul 29, 2026
pbalcer
left a comment
pbalcer
left a comment
Contributor
There was a problem hiding this comment.
mostly lgtm, one nit for the test change.
ldorau
force-pushed
the
URL0_Disable_USM_residency_P2P_restriction_by_default
branch
from
July 29, 2026 10:26
fd450f2 to
1e2a8f9
Compare
Disable the "Restrict USM residency to peers with enabled P2P access" feature by default: P2P access is now treated as enabled for all connectable peer devices out of the box, so USM allocations are made resident on all of them without requiring an explicit ext_oneapi_enable_peer_access() call. When the restriction is disabled, urUsmP2P(Enable|Disable)PeerAccessExp become no-ops that always return success, matching the behavior of the Level Zero V1 adapter. Add the SYCL_UR_L0_RESTRICT_USM_RESIDENCY_TO_P2P environment variable to opt back into the restrictive behavior on demand, requiring P2P access to be explicitly enabled for a peer before USM allocations become resident on it, and enforcing the enable/disable state machine. Update the tests that exercise this feature (sycl/test-e2e/USM/P2P/p2p_usm_residency.cpp and unified-runtime/test/adapters/level_zero/v2/memory_residency.cpp) to set the new environment variable so they keep testing the restrictive behavior. Document the new variable in EnvironmentVariables.md. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Contributor
Author
|
@kswiecicki please review. The CI failure is unrelated (issue #22812). |
Contributor
Author
|
Please review @intel/dpcpp-doc-reviewers and/or @intel/llvm-reviewers-runtime. The CI failure is unrelated (issue #22812). |
kswiecicki
approved these changes
Jul 30, 2026
Contributor
Author
|
Please review @intel/dpcpp-doc-reviewers and/or @intel/llvm-reviewers-runtime. The CI failure is unrelated (issue #22812). |
Contributor
Author
|
Please review @sergey-semenov. The CI failure is unrelated (issue #22812). |
sergey-semenov
approved these changes
Jul 30, 2026
Contributor
Author
|
Please review @intel/dpcpp-doc-reviewers. The CI failure is unrelated (issue #22812). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable the "Restrict USM residency to peers with enabled P2P access"
feature by default: P2P access is now treated as enabled for all
connectable peer devices out of the box, so USM allocations are made
resident on all of them without requiring an explicit
ext_oneapi_enable_peer_access() call. When the restriction is disabled,
urUsmP2P(Enable|Disable)PeerAccessExp become no-ops that always return
success, matching the behavior of the Level Zero V1 adapter.
Add the SYCL_UR_L0_RESTRICT_USM_RESIDENCY_TO_P2P environment variable
to opt back into the restrictive behavior on demand, requiring P2P
access to be explicitly enabled for a peer before USM allocations
become resident on it, and enforcing the enable/disable state machine.
Update the tests that exercise this feature
(sycl/test-e2e/USM/P2P/p2p_usm_residency.cpp and
unified-runtime/test/adapters/level_zero/v2/memory_residency.cpp) to
set the new environment variable so they keep testing the restrictive
behavior. Document the new variable in EnvironmentVariables.md.
Ref: #21889
Ref: MLSL-4536