feat: Add parameter for verify_messages to use optional custom dmesg …#6
Open
lkleinax wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for using a custom dmesg whitelist by introducing an optional parameter to the verify_messages method. This allows callers to override the default DMESG_WHITELIST with their own list of benign messages to ignore when checking for errors.
Changes:
- Added optional
custom_dmesg_whitelistparameter toverify_messagesmethod - Updated method to use custom whitelist when provided, falling back to default
DMESG_WHITELIST - Added parameter documentation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mchromin
requested changes
Feb 23, 2026
…whitelist Fixes intel#5 Signed-off-by: Łukasz Kleina <lukaszx.kleina@intel.com>
lkleinax
force-pushed
the
feat__Add_parameter_for_verify_messages_to_use_optional_custom_dmesg_whitelist
branch
from
0618bd7 to
140b3be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
verify_messagesmethod inmfd_dmesg/base.pyto make the list of benign messages (the whitelist) configurable, improving flexibility for users who want to customize which dmesg messages are ignored. The most important changes are:Flexibility improvements
verify_messagesmethod to accept an optionaldmesg_whitelistparameter, defaulting toDMESG_WHITELIST, allowing callers to specify a custom list of benign messages to ignore.verify_messagesto use the provideddmesg_whitelistparameter instead of the hardcodedDMESG_WHITELISTvariable when checking for benign messages.