fix: update get_messages_additional method to correctly filter number…

[adrianlasota]

This pull request refactors the get_messages_additional method in mfd_dmesg/base.py to improve type annotations, command construction logic, and test coverage. The changes enhance code clarity, ensure correct command execution, and add a dedicated test for command construction.

Type annotation improvements:

• Updated type hints for service_name, expected_return_codes, and additional_greps parameters in get_messages_additional to use more precise and modern Python type annotations, improving code readability and static analysis.

Command construction and logic changes:

• Changed the construction of the shell command in get_messages_additional so that tail -n {lines} is applied before filtering with grep, ensuring the correct subset of log lines is processed. The redundant final tail was removed. [1] [2]

Testing enhancements:

• Added a new test test_get_messages_additional_command_check in tests/unit/test_mfd_dmesg/test_base.py to verify that the correct shell command is executed when filtering by service name and line count, increasing confidence in the command construction logic.

[mfd-intel-bot]

We don't publish DEVs .whl.
To build .whl, run 'pip install git+https://github.com/intel/mfd-dmesg@filtering_issue'

[Copilot]

Pull request overview

This PR updates Dmesg.get_messages_additional() to adjust how the dmesg shell pipeline is constructed (moving tail earlier), modernizes type annotations, and adds a unit test to verify the constructed command when service_name and lines are provided.

Changes:

• Refactors get_messages_additional() command construction and tightens its type annotations.
• Adds a unit test asserting the exact command issued for service_name + lines.
• Minor formatting cleanup in mfd_dmesg/constants.py.

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.

File	Description
mfd_dmesg/base.py	Refactors get_messages_additional() typing and changes pipeline ordering to apply tail before greps.
tests/unit/test_mfd_dmesg/test_base.py	Adds a unit test to validate the executed shell command for get_messages_additional().
mfd_dmesg/constants.py	Adjusts import formatting (whitespace).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.