Fix jax vit unit tests#2467
Open
bkowalskiINTEL wants to merge 7 commits into
Open
Conversation
Signed-off-by: Bartosz Kowalski <bartosz.kowalski@intel.com>
Signed-off-by: Bartosz Kowalski <bartosz.kowalski@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the JAX ViT quantization unit test to use a more robust accuracy check by comparing top‑1 predictions (label + probability) against the original (unquantized) model, and switches test image inputs to uint8 to match the ViT example/input pipeline.
Changes:
- Switch ViT test evaluation from hardcoded top‑5 label matching to top‑1 label matching plus a probability-delta threshold.
- Add
int8to the tested quantization dtypes for the ViT classification test matrix. - Simplify
load_image()in JAX test utilities to always returnuint8(no optional normalization path).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/jax/test_vit_quantization.py |
Adjusts ViT quantization test to compare top‑1 label and probability between original and quantized models; adds int8 coverage. |
test/jax/jax_test_utility.py |
Changes load_image() to always return unnormalized uint8 image tensors. |
Signed-off-by: Bartosz Kowalski <bartosz.kowalski@intel.com>
Signed-off-by: Bartosz Kowalski <bartosz.kowalski@intel.com>
Signed-off-by: Bartosz Kowalski <bartosz.kowalski@intel.com>
e84c750 to
2e8e814
Compare
Signed-off-by: Bartosz Kowalski <bartosz.kowalski@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how the accuracy is evaluated in jax vit unit tests.
Previously: exact top-5 match with hardcoded labels
Now: exact top-1 match with label calculated on the original model + top-1 label propability error threshold
Also, now the input images for vit are in uint8 instead of float32