Revert "Fix JAX install method (#2485)"#2530
Open
bkowalskiINTEL wants to merge 2 commits into
Open
Conversation
This reverts commit 484d75d. Signed-off-by: Bartosz Kowalski <bartosz.kowalski@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates installation documentation and JAX example setup to reflect that the JAX distribution is now available on PyPI (neural-compressor-jax), removing the prior “install from source” workaround from the main README and promoting the binary install path in examples.
Changes:
- Update top-level installation instructions to use
pip install neural-compressor-jax. - Add/adjust JAX Keras example install instructions to prefer
pip install -r requirements.txt. - Extend the installation guide with a dedicated
neural-compressor-jaxinstall command and a v3.8 note.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Switches JAX install instructions to the PyPI package neural-compressor-jax. |
| examples/jax/keras/vit/requirements.txt | Adds neural-compressor-jax to the ViT example requirements. |
| examples/jax/keras/vit/README.md | Updates ViT example install instructions to emphasize binary install via requirements. |
| examples/jax/keras/gemma/requirements.txt | Introduces a requirements file for the Gemma example. |
| examples/jax/keras/gemma/README.md | Updates Gemma example install instructions to emphasize binary install via requirements. |
| docs/source/installation_guide.md | Notes JAX availability since v3.8 and adds a neural-compressor-jax install snippet. |
Comments suppressed due to low confidence (1)
examples/jax/keras/gemma/requirements.txt:2
tensorflowis listed as a requirement, but none of the Gemma JAX/Keras example scripts import or use TensorFlow. Keeping it here makes setup significantly heavier than necessary (and can introduce version conflicts).
neural-compressor-jax
| ## 2. Install modules | ||
| Install Neural Compressor from the source code: | ||
|
|
||
| After the Neural Compressor v3.8 release you can install required binaries: |
Contributor
There was a problem hiding this comment.
Please also update to 3.9
chensuyue
reviewed
Jul 20, 2026
| pip install neural-compressor-tf | ||
| ``` | ||
| ```Shell | ||
| # Framework extension API + JAX dependency, available since v3.8 |
Contributor
There was a problem hiding this comment.
This binary is available since v3.9.
chensuyue
reviewed
Jul 20, 2026
| @@ -50,8 +50,7 @@ pip install neural-compressor-pt | |||
| # Framework extension API + TensorFlow dependency | |||
| pip install neural-compressor-tf | |||
| # Framework extension API + JAX dependency, available since v3.8 | |||
Contributor
There was a problem hiding this comment.
I think we can remove this available since v3.8 in the main page.
Contributor
Author
There was a problem hiding this comment.
I agree, removed in the latest commit
Signed-off-by: Bartosz Kowalski <bartosz.kowalski@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 484d75d.
Since we've managed to publish neural-compressor-jax on PyPI, we no longer need the workaround for installing INC for JAX in the documentation.