[Decode] Fix Coverity static analysis issues in decode component

Fix 11 Coverity defects in the Decode component across MJPEG, JXS,
AV1, H264, and H265 decoders.
Also fix scan-modified-class: use RT_FUNC_ENTER(CheckGUID) and add
OFFSET_FUNC_CheckGUID to mfx_smartv_trace_offset.h.

MISSING_LOCK (data race condition) fixes:
- CID 3583175: Add m_mGuard lock to VideoDECODEMJPEG::Reset(), which
  also covers IsSameVideoParam() accessing m_response without lock
- CID 3583205: Same Reset() lock fix covers m_platform access
- CID 3583326: Add m_mGuard lock to JXS decoder Reset() for
  m_core access
- CID 3583328: Add m_mGuard lock to JXS decoder DecodeFrameCheck()
  for m_core access
- CID 3583455: Add guard lock to AV1Decoder::GetCurrFrame() for
  lastest_submitted_frame access
- CID 3583545: Same JXS Reset() lock fix covers m_platform access

INTEGER_OVERFLOW fixes:
- CID 3515335: Guard against l==0 in read_uniform() to prevent
  uint32_t underflow on l-1 when GetUnsignedBits(n)==0
- CID 3535741: Change loop variable sliceId from uint32_t to int32_t
  in H265DecoderFrameInfo::EliminateErrors() to avoid wrap-around
  overflow when resetting to -1 before continue
- CID 3541793: Change loop variable sliceId from size_t to ptrdiff_t
  in SetOfSlices::CleanUseless() to avoid underflow on --sliceId
- CID 3553573: Change loop variable pos from size_t to ptrdiff_t in
  AccessUnit::CleanUseless() to avoid underflow on pos--
- CID 3556511: Add explicit (int32_t) cast in
  DecodeExpGolombOne_H264_1u32s() when assigning uint32_t sentinel
  value 0xFFFFFFFF to int32_t *pDst

Author: stellawuintel

_studio/mfx_lib/decode/mjpeg/src/mfx_mjpeg_dec_decode.cpp

@@ -300,6 +300,8 @@ mfxStatus VideoDECODEMJPEG::Reset(mfxVideoParam *par)
     TRACE_EVENT(MFX_TRACE_API_DECODE_RESET_TASK, EVENT_TYPE_START, TR_KEY_MFX_API, make_event_data(par ? par->mfx.FrameInfo.Width : 0,
         par ? par->mfx.FrameInfo.Height : 0, par ? par->mfx.CodecId : 0));
 
+    std::lock_guard<std::mutex> guard(m_mGuard);
+
     MFX_CHECK(m_isInit, MFX_ERR_NOT_INITIALIZED);
 
     MFX_CHECK_NULL_PTR1(par);

_studio/shared/umc/codec/av1_dec/include/umc_av1_bitstream_utils.h

@@ -43,6 +43,8 @@ namespace UMC_AV1_DECODER
     inline int32_t read_uniform(AV1Bitstream& bs, uint32_t n)
     {
         const uint32_t l = UMC_VP9_DECODER::GetUnsignedBits(n);
+        if (l == 0)
+            return 0;
         const uint32_t m = (1 << l) - n;
         const uint32_t v = bs.GetBits(l - 1);
         if (v < m)

_studio/shared/umc/codec/av1_dec/include/umc_av1_decoder.h

@@ -163,7 +163,10 @@ namespace UMC_AV1_DECODER
         AV1DecoderFrame* DecodeFrameID(UMC::FrameMemID);
         AV1DecoderFrame* FindFrameInProgress();
         AV1DecoderFrame* GetCurrFrame()
-        { return lastest_submitted_frame; }
+        {
+            std::lock_guard<std::mutex> lg(guard);
+            return lastest_submitted_frame;
+        }
         UMC::FrameMemID  GetRepeatedFrame(){return repeateFrame;}
         void SetInFrameRate(mfxF64 rate)
         { in_framerate = rate; }

_studio/shared/umc/codec/h264_dec/include/umc_h264_bitstream_headers.h

@@ -391,7 +391,7 @@ inline bool DecodeExpGolombOne_H264_1u32s (uint32_t **ppBitStream,
         if ((bool)(isSigned) == true)
             *pDst = (sval & 1UL) ? (int32_t)((sval >> 1) + 1) : -(int32_t)(sval >> 1);
         else
-            *pDst = sval;
+            *pDst = (int32_t)sval;
     }
    return true;
 }

_studio/shared/umc/codec/h264_dec/src/umc_h264_au_splitter.cpp

@@ -223,7 +223,7 @@ void SetOfSlices::AddSet(const SetOfSlices *set)
 void SetOfSlices::CleanUseless()
 {
     size_t count = m_pSliceQueue.size();
-    for (size_t sliceId = 0; sliceId < count; sliceId++)
+    for (ptrdiff_t sliceId = 0; sliceId < static_cast<ptrdiff_t>(count); sliceId++)
     {
         H264Slice * curSlice = m_pSliceQueue[sliceId];
         if (curSlice->m_bDecoded)
@@ -328,7 +328,7 @@ size_t AccessUnit::GetLayersCount() const
 void AccessUnit::CleanUseless()
 {
     size_t count = m_layers.size();
-    for (size_t pos = 0; pos < count; pos++)
+    for (ptrdiff_t pos = 0; pos < static_cast<ptrdiff_t>(count); pos++)
     {
         SetOfSlices * set = &m_layers[pos];
         set->CleanUseless();

_studio/shared/umc/codec/h265_dec/src/umc_h265_frame_info.cpp

@@ -102,14 +102,14 @@ void H265DecoderFrameInfo::EliminateErrors()
         return;
 
     // Remove dependent slices without a corresponding independent slice
-    for (uint32_t sliceId = 0; sliceId < GetSliceCount(); sliceId++)
+    for (int32_t sliceId = 0; sliceId < static_cast<int32_t>(GetSliceCount()); sliceId++)
     {
         H265Slice * slice = GetSlice(sliceId);
 
         if (slice->GetSliceHeader()->dependent_slice_segment_flag)
         {
             RemoveSlice(sliceId);
-            sliceId = uint32_t(-1);
+            sliceId = -1;
             continue;
         }
         else
@@ -121,7 +121,7 @@ void H265DecoderFrameInfo::EliminateErrors()
         H265Slice *baseSlice = GetSlice(0); // after the for() loop above ,the first slice is treated as 'base' slice
 
         bool bIndepSliceMissing = false;
-        for (uint32_t sliceId = 1; sliceId < GetSliceCount(); sliceId++)
+        for (int32_t sliceId = 1; sliceId < static_cast<int32_t>(GetSliceCount()); sliceId++)
         {
             H265SliceHeader *sliceHeader = GetSlice(sliceId)->GetSliceHeader();
 
@@ -144,7 +144,7 @@ void H265DecoderFrameInfo::EliminateErrors()
     }
 
     // Remove slices with duplicated slice_segment_address syntax
-    for (uint32_t sliceId = 0; sliceId < GetSliceCount(); sliceId++)
+    for (int32_t sliceId = 0; sliceId < static_cast<int32_t>(GetSliceCount()); sliceId++)
     {
         H265Slice * slice     = m_pSliceQueue[sliceId];
         H265Slice * nextSlice = GetSlice(sliceId + 1);
@@ -154,7 +154,7 @@ void H265DecoderFrameInfo::EliminateErrors()
 
         if (slice->GetFirstMB() == slice->GetMaxMB())
         {
-            uint32_t sliceIdToRemove;
+            int32_t sliceIdToRemove;
 
             // Heuristic logic:
             if (slice->GetSliceHeader()->dependent_slice_segment_flag && !nextSlice->GetSliceHeader()->dependent_slice_segment_flag)
@@ -168,7 +168,7 @@ void H265DecoderFrameInfo::EliminateErrors()
                 sliceIdToRemove = sliceId + 1;
             }
             RemoveSlice(sliceIdToRemove);
-            sliceId = uint32_t(-1);
+            sliceId = -1;
             continue;
         }
     }