[Decode] Correct luma and chroma offsets

vcheah · vcheah · commit ae0991055d03 · 2026-06-10T20:25:44.000+08:00
diff --git a/_studio/shared/umc/codec/h264_dec/src/umc_h264_dec_bitstream_headers.cpp b/_studio/shared/umc/codec/h264_dec/src/umc_h264_dec_bitstream_headers.cpp
@@ -1919,7 +1919,6 @@ Status H264HeadersBitstream::GetPredWeightTable(
         {
             pPredWeight_L0[refindex].luma_weight = (int8_t)GetVLCElement(true);
             pPredWeight_L0[refindex].luma_offset = (int8_t)GetVLCElement(true);
-            pPredWeight_L0[refindex].luma_offset <<= (sps->bit_depth_luma - 8);
         }
         else
         {
@@ -1939,9 +1938,6 @@ Status H264HeadersBitstream::GetPredWeightTable(
             pPredWeight_L0[refindex].chroma_offset[0] = (int8_t)GetVLCElement(true);
             pPredWeight_L0[refindex].chroma_weight[1] = (int8_t)GetVLCElement(true);
             pPredWeight_L0[refindex].chroma_offset[1] = (int8_t)GetVLCElement(true);
-
-            pPredWeight_L0[refindex].chroma_offset[0] <<= (sps->bit_depth_chroma - 8);
-            pPredWeight_L0[refindex].chroma_offset[1] <<= (sps->bit_depth_chroma - 8);
         }
         else
         {
@@ -1961,7 +1957,6 @@ Status H264HeadersBitstream::GetPredWeightTable(
             {
                 pPredWeight_L1[refindex].luma_weight = (int8_t)GetVLCElement(true);
                 pPredWeight_L1[refindex].luma_offset = (int8_t)GetVLCElement(true);
-                pPredWeight_L1[refindex].luma_offset <<= (sps->bit_depth_luma - 8);
             }
             else
             {
@@ -1979,9 +1974,6 @@ Status H264HeadersBitstream::GetPredWeightTable(
                 pPredWeight_L1[refindex].chroma_offset[0] = (int8_t)GetVLCElement(true);
                 pPredWeight_L1[refindex].chroma_weight[1] = (int8_t)GetVLCElement(true);
                 pPredWeight_L1[refindex].chroma_offset[1] = (int8_t)GetVLCElement(true);
-
-                pPredWeight_L1[refindex].chroma_offset[0] <<= (sps->bit_depth_chroma - 8);
-                pPredWeight_L1[refindex].chroma_offset[1] <<= (sps->bit_depth_chroma - 8);
             }
             else
             {

Original file line number	Diff line number	Diff line change
`@@ -1919,7 +1919,6 @@ Status H264HeadersBitstream::GetPredWeightTable(`
`1919`	`1919`	`{`
`1920`	`1920`	`pPredWeight_L0[refindex].luma_weight = (int8_t)GetVLCElement(true);`
`1921`	`1921`	`pPredWeight_L0[refindex].luma_offset = (int8_t)GetVLCElement(true);`
`1922`		`- pPredWeight_L0[refindex].luma_offset <<= (sps->bit_depth_luma - 8);`
`1923`	`1922`	`}`
`1924`	`1923`	`else`
`1925`	`1924`	`{`
`@@ -1939,9 +1938,6 @@ Status H264HeadersBitstream::GetPredWeightTable(`
`1939`	`1938`	`pPredWeight_L0[refindex].chroma_offset[0] = (int8_t)GetVLCElement(true);`
`1940`	`1939`	`pPredWeight_L0[refindex].chroma_weight[1] = (int8_t)GetVLCElement(true);`
`1941`	`1940`	`pPredWeight_L0[refindex].chroma_offset[1] = (int8_t)GetVLCElement(true);`
`1942`		`-`
`1943`		`- pPredWeight_L0[refindex].chroma_offset[0] <<= (sps->bit_depth_chroma - 8);`
`1944`		`- pPredWeight_L0[refindex].chroma_offset[1] <<= (sps->bit_depth_chroma - 8);`
`1945`	`1941`	`}`
`1946`	`1942`	`else`
`1947`	`1943`	`{`
`@@ -1961,7 +1957,6 @@ Status H264HeadersBitstream::GetPredWeightTable(`
`1961`	`1957`	`{`
`1962`	`1958`	`pPredWeight_L1[refindex].luma_weight = (int8_t)GetVLCElement(true);`
`1963`	`1959`	`pPredWeight_L1[refindex].luma_offset = (int8_t)GetVLCElement(true);`
`1964`		`- pPredWeight_L1[refindex].luma_offset <<= (sps->bit_depth_luma - 8);`
`1965`	`1960`	`}`
`1966`	`1961`	`else`
`1967`	`1962`	`{`
`@@ -1979,9 +1974,6 @@ Status H264HeadersBitstream::GetPredWeightTable(`
`1979`	`1974`	`pPredWeight_L1[refindex].chroma_offset[0] = (int8_t)GetVLCElement(true);`
`1980`	`1975`	`pPredWeight_L1[refindex].chroma_weight[1] = (int8_t)GetVLCElement(true);`
`1981`	`1976`	`pPredWeight_L1[refindex].chroma_offset[1] = (int8_t)GetVLCElement(true);`
`1982`		`-`
`1983`		`- pPredWeight_L1[refindex].chroma_offset[0] <<= (sps->bit_depth_chroma - 8);`
`1984`		`- pPredWeight_L1[refindex].chroma_offset[1] <<= (sps->bit_depth_chroma - 8);`
`1985`	`1977`	`}`
`1986`	`1978`	`else`
`1987`	`1979`	`{`